update codec to use mux not mixer #703
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
If you use mux, how do you pick the mic? Mixer as implemented combines the mics. |
Contributor
Author
|
Assume I know what a mixer does. Why do you think this pr exists? What problem is it trying to solve? |
Contributor
|
It seems we need some analysis of the effect of this on range and directionality. The idea now is to treat the three mics as a broadside array (pointing up and out) to improve both, would be interesting if simply picking one is better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mixer seems to cause crackle. Replaced it with a mux in the codec program.
This appears to be a separate issue from the firmware bug that Divya fixed in here: #702