Fix auto trader trades with additional item data#324
Draft
PsyGuy007-sys wants to merge 1 commit into
Draft
Conversation
PsyGuy007-sys
force-pushed
the
fix/322-auto-trader-nbt
branch
from
July 17, 2026 08:48
7369a50 to
a211629
Compare
Owner
|
Is this still WIP? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ItemCostpredicate.Why
The auto trader previously converted the offer's displayed cost stack into an
ItemResourceand extracted it by exact resource equality. Items with additional data components, such as Productive Farming crops or theminecraft:custom_dataexample from #322, therefore failed to match even though vanilla villager trading accepts them.Using
ItemCost.testaligns automatic trading withMerchantOffer.satisfiedBy: additional components are allowed, while components required by the offer still have to match.Impact
Auto traders can now consume otherwise valid trade inputs carrying additional data components. Multi-slot extraction and transactional rollback behavior are preserved.
Validation
./gradlew buildminecraft:custom_dataCloses #322