Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(omitable feature): now we can have omitable fields to create val… #59

Closed
wants to merge 1 commit into from

Conversation

italojs
Copy link
Member

@italojs italojs commented Mar 23, 2022

Fixes #49

asValueObject() method returns a new entity without omitable fields

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • Remember to check if code coverage decrease, if so, please implement the necessary tests

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #59 (82a64ef) into master (8bf3f3d) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 82a64ef differs from pull request most recent head bf66fe8. Consider uploading reports for the commit bf66fe8 to get more accurate results

@@            Coverage Diff            @@
##            master       #59   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          108       112    +4     
=========================================
+ Hits           108       112    +4     
Impacted Files Coverage Δ
src/entity.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84bb2c3...bf66fe8. Read the comment docs.

@jhomarolo
Copy link
Contributor

This is still valid?

@dalssoft
Copy link
Member

dalssoft commented Jan 3, 2023

@italojs , given the direction of the discussion, do you think that we can close this issue here?

Entity schema to Request schema: herbsjs/buchu#53

Partial or Custom Entity Validation: #70

@italojs italojs closed this Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

omit entity properties into usecase
3 participants