fix(detect): update Grok agent detection rules for Grok Build 1.0.x - #2764
fix(detect): update Grok agent detection rules for Grok Build 1.0.x#2764jasonchen36 wants to merge 1 commit into
Conversation
- Add 'ctrl+x:shortcuts' and 'shift+tab:mode' to prompt_hints_idle matcher to recognize modern Grok Build idle prompt footers. - Increase prompt_hints_idle priority to 1160 and osc_title_idle to 1140 so idle prompt/title state outranks historical subagent/tool lines in scrollback. - Remove 'ctrl+.:shortcuts' from esc_cancel_hints_working to prevent false-positive working status on idle prompts. - Deprioritize osc_progress_working to priority 900 because Grok 1.0.x does not emit OSC 9;4;0;0 when yielding to prompt. - Synchronize bundled src/detect/manifests/grok.toml and website/agent-detection/grok.toml.
|
Hi @jasonchen36, thanks for your interest in contributing. Herdr does not accept unsolicited implementation pull requests from contributors who are not listed in The pull request author is not an approved contributor. If you encountered a reproducible bug, report the observed behavior through the bug issue template. A report does not reserve the work or authorize a pull request; accepted fixes are normally implemented by Herdr’s maintainer-controlled agents. Feature requests, behavior changes, and other proposals belong in GitHub Discussions. Do not open an issue merely to justify an implementation that was already written. If a maintainer explicitly wants this implementation, they can reopen the pull request. Reopening by anyone else will be closed again automatically. See https://github.com/herdrdev/herdr/blob/master/CONTRIBUTING.md for the contribution policy. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
Idle Grok Build 1.0.x agents were incorrectly classified as
working(yellow filled status indicator in Herdr) when idle at the prompt for two main reasons:prompt_hints_idleonly matchedctrl+.:shortcuts, but Grok Build 1.0.x rendersCtrl+x:shortcutsorShift+Tab:modein the prompt footer.esc_cancel_hints_workingerroneously containedctrl+.:shortcuts, marking idle prompts as working.osc_progress_working(priority 1150) outranked title/prompt idle rules, but Grok Build 1.0.x emitsOSC 9;4;1;-1during turn execution without sendingOSC 9;4;0;0to clear progress upon yielding.┃ ◆) in scrollback buffer outranked title/prompt idle rules.Solution
ctrl+x:shortcutsandshift+tab:modetoprompt_hints_idlematcher and boosted its priority to 1160 so idle prompt footers outrank scrollback transcript history.osc_title_idlepriority to 1140 and made regex case-insensitive and flexible across title variations.ctrl+.:shortcutsfromesc_cancel_hints_working.osc_progress_workingto priority 900 below prompt/title idle rules.src/detect/manifests/grok.tomlandwebsite/agent-detection/grok.toml.Verification
python3 scripts/agent_detection_manifest_check.py --require-website.python3 scripts/test_agent_detection_manifest_check.py.