Skip to content

fix: detect qwen localized active states - #2818

Merged
ogulcancelik merged 2 commits into
masterfrom
issue/2756-qwen-status-detection
Aug 14, 2026
Merged

fix: detect qwen localized active states#2818
ogulcancelik merged 2 commits into
masterfrom
issue/2756-qwen-status-detection

Conversation

@ogulcancelik

Copy link
Copy Markdown
Collaborator

Summary

  • prioritize Qwen Code’s locale-independent ◐︎ working and ✳︎ blocked terminal-title signals
  • add source-derived fallbacks for narrow working indicators, localized confirmation text, and ask_user_question dialogs
  • synchronize the downloadable detection manifest and next-release changelog

Testing

  • just check
  • live Qwen Code 0.21.11 verification in a disposable source-build Herdr session: working, English approval, Chinese approval, and Chinese question dialog

Refs #2756

@kangal-bot kangal-bot added the ai-review Trigger automated AI reviews for pull requests admitted by the PR gate label Aug 14, 2026
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fd87d464-e7c4-4047-b6d0-77f11de01573

📥 Commits

Reviewing files that changed from the base of the PR and between d76657f and 1d56565.

📒 Files selected for processing (3)
  • docs/next/CHANGELOG.md
  • src/detect/manifests/qwen.toml
  • website/agent-detection/qwen.toml

📝 Walkthrough

Walkthrough

Changes

The Qwen detection rules now support locale-independent terminal titles, localized confirmation prompts, broader question dialogs, and elapsed-time cancellation hints. The changelog records these updates.

Qwen detection updates

Layer / File(s) Summary
Terminal state and confirmation detection
src/detect/manifests/qwen.toml, website/agent-detection/qwen.toml, docs/next/CHANGELOG.md
The manifests add blocked and working OSC-title rules. Confirmation detection now uses spinner lines and localized waiting phrases. The changelog documents the state-detection update.
Prompt and cancellation detection
src/detect/manifests/qwen.toml, website/agent-detection/qwen.toml
Question dialogs now support numbered options, selected choices, and keyboard navigation prompts. Working-state detection now requires elapsed-time cancellation text.

Estimated code review effort: 2 (Simple) | ~15 minutes

Merge Risk: ⚪ Minimal · up to 1d565

The PR adds localized Qwen status detection patterns and synchronized manifest and changelog updates; no actionable merge-blocking risk remains, so it is merge-ready after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the primary change: detecting localized active Qwen states.
Description check ✅ Passed The description accurately covers the Qwen detection updates, synchronized manifests, changelog, and testing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue/2756-qwen-status-detection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ogulcancelik

Copy link
Copy Markdown
Collaborator Author

@greptileai

@greptile-apps

greptile-apps Bot commented Aug 14, 2026

Copy link
Copy Markdown

Greptile Summary

The PR updates Qwen Code state detection to recognize locale-independent terminal-title signals and localized blocked-state screen fallbacks.

  • Adds high-priority OSC title rules for working and blocked states.
  • Expands confirmation and question-dialog detection across localized and narrow-terminal renderings.
  • Synchronizes the bundled and downloadable manifests and documents the fix in the next-release changelog.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/detect/manifests/qwen.toml Adds prioritized OSC-title and localized screen rules for Qwen working and blocked states; no eligible follow-up defect was established.
website/agent-detection/qwen.toml Keeps the downloadable Qwen detection manifest synchronized with the bundled manifest.
docs/next/CHANGELOG.md Records the Qwen localized active-state detection fix for the next release.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Qwen[Qwen Code terminal output] --> OSC[OSC title and progress]
  Qwen --> Screen[Recent screen lines]
  OSC --> Rules[Priority-ordered Qwen manifest rules]
  Screen --> Rules
  Rules --> State{Detected state}
  State --> Working[Working]
  State --> Blocked[Blocked]
  State --> Idle[Idle]
Loading

Reviews (2): Last reviewed commit: "Merge branch 'master' into issue/2756-qw..." | Re-trigger Greptile

@yiliang114

Copy link
Copy Markdown

I verified the requested Qwen path locally against 1d56565d9eb74f4074e9a7eaf2c34a92c67eefaa, using a source-built Herdr binary and Qwen Code 0.21.11 with the Chinese UI in an isolated session.

  • Working: while !sleep 30 was running, Qwen set the terminal title to ◐︎ Qwen - herdr-pr2818-fixture. Herdr reported agent_status: working, and agent explain matched osc_title_working.
  • Blocked: I asked Qwen to run touch /tmp/herdr-pr2818-blocked-evidence and left the Chinese permission dialog unapproved. Qwen set the title to ✳︎ Create evidence file for herdr-pr2818; Herdr reported agent_status: blocked, and agent explain matched osc_title_blocked. The marker file was not created.

Both state transitions behaved as expected in the requested runtime case. The blocked screenshot represents the expected “waiting for user approval” state, not an unresolved failure.

Working

Qwen working state in Herdr

Blocked

Qwen blocked state in Herdr

@ogulcancelik
ogulcancelik merged commit 9e6c2b4 into master Aug 14, 2026
8 checks passed
@kangal-bot kangal-bot removed the ai-review Trigger automated AI reviews for pull requests admitted by the PR gate label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants