Updated indoor map example based on user feedback #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Intellias\ihnativ <[email protected]>
More information on the use of the HERE Indoor Maps API now points at the correct link. Signed-off-by: Intellias\ihnativ <[email protected]>
There's now a reference to the description of optional variables mentioned in the code example. Signed-off-by: Intellias\ihnativ <[email protected]>
The drawingId variable in the example wasn't defined as optional, whereas it is such according to the user feedaback. Signed-off-by: Intellias\ihnativ <[email protected]>
The variable platform was missing from the function addVenueToMap Signed-off-by: Intellias\ihnativ <[email protected]>
hnativ13
force-pushed
the
Updated-indoor-map-example-based-on-user-feedback
branch
from
8cfb61b to
956e3ff
Compare
|
Hi @hnativ13, the diff shows changes that were already introduced in a previous commit. Could you please check that your branch is correctly rebased? |
Hello @dbacarel - it looks like the branch was rebased correctly, I'm not sure why my commit captured a commit from 11 November 2022. Do I need to remove this change that was already introduced in a previous commit from my pull request? |
|
strange, in order to not mess up the history, would you mind creating a separate PR? I see that the changes are few and very minor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.