Skip to content

Updated indoor map example based on user feedback #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hnativ13
Copy link

@hnativ13 hnativ13 commented Feb 7, 2023

No description provided.

dbacarel and others added 5 commits February 7, 2023 14:52
More information on the use of the HERE Indoor Maps API now points at the correct link.

Signed-off-by: Intellias\ihnativ <[email protected]>
There's now a reference to the description of optional variables mentioned in the code example.

Signed-off-by: Intellias\ihnativ <[email protected]>
The drawingId variable in the example wasn't defined as optional, whereas it is such according to the user feedaback.

Signed-off-by: Intellias\ihnativ <[email protected]>
 The variable platform was missing from the function addVenueToMap

Signed-off-by: Intellias\ihnativ <[email protected]>
@hnativ13 hnativ13 force-pushed the Updated-indoor-map-example-based-on-user-feedback branch from 8cfb61b to 956e3ff Compare February 7, 2023 12:53
@dbacarel
Copy link
Member

dbacarel commented Feb 8, 2023

Hi @hnativ13, the diff shows changes that were already introduced in a previous commit. Could you please check that your branch is correctly rebased?

@hnativ13
Copy link
Author

hnativ13 commented Feb 8, 2023

Hi @hnativ13, the diff shows changes that were already introduced in a previous commit. Could you please check that your branch is correctly rebased?

Hello @dbacarel - it looks like the branch was rebased correctly, I'm not sure why my commit captured a commit from 11 November 2022. Do I need to remove this change that was already introduced in a previous commit from my pull request?

@dbacarel
Copy link
Member

dbacarel commented Feb 8, 2023

strange, in order to not mess up the history, would you mind creating a separate PR? I see that the changes are few and very minor

@hnativ13
Copy link
Author

hnativ13 commented Feb 9, 2023

strange, in order to not mess up the history, would you mind creating a separate PR? I see that the changes are few and very minor

Hi @dbacarel - sorry, this took me a little longer than I thought, but here it is - a separate PR: #147

@dbacarel dbacarel closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants