Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

added support for travis CI #39

Merged
merged 5 commits into from
Oct 26, 2018
Merged

added support for travis CI #39

merged 5 commits into from
Oct 26, 2018

Conversation

adrpar
Copy link
Contributor

@adrpar adrpar commented Oct 19, 2018

No description provided.

@adrpar adrpar requested a review from delfrrr October 19, 2018 13:52
@adrpar adrpar mentioned this pull request Oct 19, 2018
@adrpar adrpar force-pushed the travis.adrpar branch 20 times, most recently from f3db9a6 to 9427a2b Compare October 23, 2018 12:48
@adrpar adrpar force-pushed the travis.adrpar branch 3 times, most recently from 1d72b72 to c6067a5 Compare October 24, 2018 05:54
@adrpar adrpar force-pushed the travis.adrpar branch 2 times, most recently from 3d8eb98 to 3e8c9d5 Compare October 24, 2018 06:05
@adrpar adrpar force-pushed the travis.adrpar branch 11 times, most recently from 78e935e to cb41771 Compare October 24, 2018 14:13
@adrpar adrpar force-pushed the travis.adrpar branch 4 times, most recently from 3cd21f9 to 952dd7e Compare October 25, 2018 07:30
@adrpar adrpar force-pushed the travis.adrpar branch 4 times, most recently from 8dc10a0 to c7dfa17 Compare October 25, 2018 12:00
@adrpar
Copy link
Contributor Author

adrpar commented Oct 25, 2018

Added all tests as mentioned in issue #25.

Fsanitize on gcc is unfortunately failing, so there must be a memory issue some where (I have clions static analyzer throwing various errors, I guess it has to be one of these).

Further, gcc release built only works with O2 optimization flag, most likely due to memory corruption issue that also lets fsanitize fail. But for the start, that's where we are.

@adrpar adrpar requested a review from fester October 25, 2018 13:12
@fester fester merged commit 0c7ebca into heremaps:master Oct 26, 2018
- sudo apt install libgdal-dev gdal-bin

script:
- if [ $TEST_TASK == 'test' ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to see it in a Makefile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. We should put all the different targets and test execution into the cmake file. And this reminds me, we should also add an installation target, so that 'make install' will work.

This will not replace the switch case statement though, since this is the only way to have completely different build methods in Travis matrix (or I was not able to find a better solution).

I will create a new issue for the additional cmake targets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: #41

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants