Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A verified reupload currently cannot repair an existing truncated CAS blob. A same-size zero-filled blob also passes the size-only check, leaving the cache unusable even when the client sends the correct contents again.
Hash existing blobs on upload/promotion collisions and atomically replace invalid contents with the verified incoming inode. Keep
Store.hasas the inexpensive size check; this does not add a full-file hash to every cache lookup. Symlink/non-file collisions remain errors.The regression cases cover truncated and same-size corruption through anonymous uploads, the named-file fallback, and same-filesystem promotion. They run in the existing
//src:unit_teststarget; no additional CAS-only test target is needed.Validation was performed with these fixes combined in a Linux KVM integration workspace, using actiond for execution and caching. The native unit suite, filesystem probes, and a large mixed-language Bazel workload passed. These draft changes have not been validated with
tools/e2e.sh vmon macOS.