Fix trailing whitespace in output functions #285
Draft
+57
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malax
added
the
skip changelog
Malax
force-pushed
the
malax/whitespace
branch
from
e7aa342 to
e70f176
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output functions (notice, warning, error) were adding fixed indentation even on empty lines, resulting in trailing whitespace in build output. This made working with Hatchet tests problematic since trailing spaces are difficult to debug when tests fail.
Changed the output functions to only add indentation when the line has content, keeping empty lines truly empty. Extended the
clean_outputhelper to strip remaining trailing spaces from Heroku'sremote:lines and sbt log output. Updated all test specs to match the cleaner output format.GUS-W-20064656