Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): use builder for regexes #872

Merged
merged 3 commits into from
Oct 1, 2024
Merged

test(e2e): use builder for regexes #872

merged 3 commits into from
Oct 1, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Sep 23, 2024

This PR introduces a new builder for regular expressions, which makes tests easier to understand and maintain.

@phm07 phm07 self-assigned this Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.63%. Comparing base (120aa03) to head (8413f66).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
test/e2e/util.go 96.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
+ Coverage   71.45%   71.63%   +0.17%     
==========================================
  Files         243      244       +1     
  Lines        8731     8791      +60     
==========================================
+ Hits         6239     6297      +58     
- Misses       1824     1826       +2     
  Partials      668      668              
Flag Coverage Δ
e2e 44.28% <96.66%> (+0.37%) ⬆️
unit 65.96% <0.00%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phm07 phm07 marked this pull request as ready for review September 30, 2024 11:44
@phm07 phm07 requested a review from a team as a code owner September 30, 2024 11:44
@phm07 phm07 merged commit 6588e84 into main Oct 1, 2024
6 checks passed
@phm07 phm07 deleted the e2e-regex branch October 1, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants