Slim onboarding view, use the app icon, hint at the CLI - #14
Conversation
hewigovens
commented
Apr 25, 2026
hewigovens
commented
- Hero image switches from the magnifyingglass.circle.fill SF Symbol to NSImage.applicationIconName so the running app's icon is shown instead of a generic system glyph.
- Drop the two-paragraph permission/folder explanation; the choose-folder dialog already conveys what's happening.
- Add a one-line tip pointing to the App Detective menu's "Install Command Line Tool…" item for users who want to inspect a single app from a terminal.
- Tighten vertical spacing now that there's less copy.
- Hero image switches from the magnifyingglass.circle.fill SF Symbol to NSImage.applicationIconName so the running app's icon is shown instead of a generic system glyph. - Drop the two-paragraph permission/folder explanation; the choose-folder dialog already conveys what's happening. - Add a one-line tip pointing to the App Detective menu's "Install Command Line Tool…" item for users who want to inspect a single app from a terminal. - Tighten vertical spacing now that there's less copy.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the OnboardingView by tightening the layout spacing, replacing the generic magnifying glass icon with the application icon, and simplifying the instructional text. It also adds a tip regarding the CLI installation. A review comment points out that the use of a Spacer within the VStack results in a larger vertical gap than intended and suggests using padding instead for better layout control.
| Spacer().frame(height: 4) | ||
|
|
There was a problem hiding this comment.
In a VStack with spacing: 16, adding a Spacer().frame(height: 4) results in a total vertical gap of 36pt (16pt spacing + 4pt spacer + 16pt spacing) between the preceding element and the tip text. This seems to contradict the goal of "tightening" the layout mentioned in the PR description. If the intention was to add a small extra margin, consider using .padding(.top, 4) on the Text view instead, or simply remove the Spacer to maintain the consistent 16pt spacing.
1 participant
