Fix non-admin scan failures - #15
Conversation
- Hero image switches from the magnifyingglass.circle.fill SF Symbol to NSImage.applicationIconName so the running app's icon is shown instead of a generic system glyph. - Drop the two-paragraph permission/folder explanation; the choose-folder dialog already conveys what's happening. - Add a one-line tip pointing to the App Detective menu's "Install Command Line Tool…" item for users who want to inspect a single app from a terminal. - Tighten vertical spacing now that there's less copy.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to specify a startup scan folder via command-line arguments and improves the CLI installation process by providing shell-specific path hints and checking the login shell's PATH. It also enhances the scanning engine to gracefully handle and report permission-denied errors in subdirectories without failing the entire scan. Feedback highlights a potential UI hang due to synchronous process execution on the main thread, an invalid macOS deployment target in the project configuration, a logic flaw in argument parsing, and a potential deadlock when reading shell output.
55ccf5f to
71abe96
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71abe96d5b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
71abe96 to
80d541d
Compare
1 participant
Summary
--scan-folderstartup option and document itValidation
just testjust release-dry-run 1.4.1Notes
This PR is draft while the 1.4.1 dry-run build is tested on a standard non-admin macOS user account.