Skip to content

fix(client-axios): Fix axios error handling without ts errors #2821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

fix(client-axios): Fix axios error handling without ts errors #2821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e1c5162
Fix axios error handling without ts errors
mauriciabad Oct 23, 2025
206b887
Update snapshots
mauriciabad Oct 23, 2025
812c16f
Forgot a return
mauriciabad Oct 23, 2025
95f2ead
Update snapshots
mauriciabad Oct 23, 2025
d6ccdb6
Revert "Update snapshots"
mauriciabad Oct 23, 2025
43118ab
Revert "Update snapshots"
mauriciabad Oct 23, 2025
f2b5253
Update snapshots finally...
mauriciabad Oct 23, 2025
c3d62f0
Update examples
mauriciabad Oct 23, 2025
94c01be
update examples openai
mauriciabad Oct 23, 2025
7f71c2c
Merge branch 'main' into patch-2
mauriciabad Oct 26, 2025
6f05c9b
Merge branch 'main' into patch-2
mauriciabad Oct 29, 2025
c54bcdf
Merge branch 'main' into patch-2
mauriciabad Oct 31, 2025
58e694a
Merge branch 'main' into patch-2
mauriciabad Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions examples/openapi-ts-axios/src/client/client/client.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// This file is auto-generated by @hey-api/openapi-ts

import type { AxiosError, AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios from 'axios';
import type { AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios, { AxiosError } from 'axios';

import { createSseClient } from '../core/serverSentEvents.gen';
import type { HttpMethod } from '../core/types.gen';
Expand Down Expand Up @@ -69,7 +69,7 @@ export const createClient = (config: Config = {}): Client => {
return { opts, url };
};

// @ts-expect-error
// @ts-expect-error is not assignable to type RequestResult
const request: Client['request'] = async (options) => {
// @ts-expect-error
const { opts, url } = await beforeRequest(options);
Expand All @@ -87,6 +87,7 @@ export const createClient = (config: Config = {}): Client => {
params: opts.paramsSerializer ? opts.query : undefined,
url,
});
if (response instanceof Error) throw response;

let { data } = response;

Expand All @@ -105,13 +106,17 @@ export const createClient = (config: Config = {}): Client => {
data: data ?? {},
};
} catch (error) {
const e = error as AxiosError;
if (opts.throwOnError) {
throw e;
throw error;
}
// @ts-expect-error
e.error = e.response?.data ?? {};
return e;

if (error instanceof AxiosError) {
// @ts-expect-error Property 'error' does not exist on type 'AxiosError<any, any>'.ts(2339)
error.error = error.response?.data ?? {};
return error;
}

return { error: {} };
}
};

Expand Down
21 changes: 13 additions & 8 deletions ...snapshots__/2.0.x/plugins/@tanstack/angular-query-experimental/axios/client/client.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// This file is auto-generated by @hey-api/openapi-ts

import type { AxiosError, AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios from 'axios';
import type { AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios, { AxiosError } from 'axios';

import { createSseClient } from '../core/serverSentEvents.gen';
import type { HttpMethod } from '../core/types.gen';
Expand Down Expand Up @@ -69,7 +69,7 @@ export const createClient = (config: Config = {}): Client => {
return { opts, url };
};

// @ts-expect-error
// @ts-expect-error is not assignable to type RequestResult
const request: Client['request'] = async (options) => {
// @ts-expect-error
const { opts, url } = await beforeRequest(options);
Expand All @@ -87,6 +87,7 @@ export const createClient = (config: Config = {}): Client => {
params: opts.paramsSerializer ? opts.query : undefined,
url,
});
if (response instanceof Error) throw response;

let { data } = response;

Expand All @@ -105,13 +106,17 @@ export const createClient = (config: Config = {}): Client => {
data: data ?? {},
};
} catch (error) {
const e = error as AxiosError;
if (opts.throwOnError) {
throw e;
throw error;
}
// @ts-expect-error
e.error = e.response?.data ?? {};
return e;

if (error instanceof AxiosError) {
// @ts-expect-error Property 'error' does not exist on type 'AxiosError<any, any>'.ts(2339)
error.error = error.response?.data ?? {};
return error;
}

return { error: {} };
}
};

Expand Down
21 changes: 13 additions & 8 deletions ...ts/main/test/__snapshots__/2.0.x/plugins/@tanstack/react-query/axios/client/client.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// This file is auto-generated by @hey-api/openapi-ts

import type { AxiosError, AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios from 'axios';
import type { AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios, { AxiosError } from 'axios';

import { createSseClient } from '../core/serverSentEvents.gen';
import type { HttpMethod } from '../core/types.gen';
Expand Down Expand Up @@ -69,7 +69,7 @@ export const createClient = (config: Config = {}): Client => {
return { opts, url };
};

// @ts-expect-error
// @ts-expect-error is not assignable to type RequestResult
const request: Client['request'] = async (options) => {
// @ts-expect-error
const { opts, url } = await beforeRequest(options);
Expand All @@ -87,6 +87,7 @@ export const createClient = (config: Config = {}): Client => {
params: opts.paramsSerializer ? opts.query : undefined,
url,
});
if (response instanceof Error) throw response;

let { data } = response;

Expand All @@ -105,13 +106,17 @@ export const createClient = (config: Config = {}): Client => {
data: data ?? {},
};
} catch (error) {
const e = error as AxiosError;
if (opts.throwOnError) {
throw e;
throw error;
}
// @ts-expect-error
e.error = e.response?.data ?? {};
return e;

if (error instanceof AxiosError) {
// @ts-expect-error Property 'error' does not exist on type 'AxiosError<any, any>'.ts(2339)
error.error = error.response?.data ?? {};
return error;
}

return { error: {} };
}
};

Expand Down
21 changes: 13 additions & 8 deletions ...ts/main/test/__snapshots__/2.0.x/plugins/@tanstack/solid-query/axios/client/client.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// This file is auto-generated by @hey-api/openapi-ts

import type { AxiosError, AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios from 'axios';
import type { AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios, { AxiosError } from 'axios';

import { createSseClient } from '../core/serverSentEvents.gen';
import type { HttpMethod } from '../core/types.gen';
Expand Down Expand Up @@ -69,7 +69,7 @@ export const createClient = (config: Config = {}): Client => {
return { opts, url };
};

// @ts-expect-error
// @ts-expect-error is not assignable to type RequestResult
const request: Client['request'] = async (options) => {
// @ts-expect-error
const { opts, url } = await beforeRequest(options);
Expand All @@ -87,6 +87,7 @@ export const createClient = (config: Config = {}): Client => {
params: opts.paramsSerializer ? opts.query : undefined,
url,
});
if (response instanceof Error) throw response;

let { data } = response;

Expand All @@ -105,13 +106,17 @@ export const createClient = (config: Config = {}): Client => {
data: data ?? {},
};
} catch (error) {
const e = error as AxiosError;
if (opts.throwOnError) {
throw e;
throw error;
}
// @ts-expect-error
e.error = e.response?.data ?? {};
return e;

if (error instanceof AxiosError) {
// @ts-expect-error Property 'error' does not exist on type 'AxiosError<any, any>'.ts(2339)
error.error = error.response?.data ?? {};
return error;
}

return { error: {} };
}
};

Expand Down
21 changes: 13 additions & 8 deletions ...s/main/test/__snapshots__/2.0.x/plugins/@tanstack/svelte-query/axios/client/client.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// This file is auto-generated by @hey-api/openapi-ts

import type { AxiosError, AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios from 'axios';
import type { AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios, { AxiosError } from 'axios';

import { createSseClient } from '../core/serverSentEvents.gen';
import type { HttpMethod } from '../core/types.gen';
Expand Down Expand Up @@ -69,7 +69,7 @@ export const createClient = (config: Config = {}): Client => {
return { opts, url };
};

// @ts-expect-error
// @ts-expect-error is not assignable to type RequestResult
const request: Client['request'] = async (options) => {
// @ts-expect-error
const { opts, url } = await beforeRequest(options);
Expand All @@ -87,6 +87,7 @@ export const createClient = (config: Config = {}): Client => {
params: opts.paramsSerializer ? opts.query : undefined,
url,
});
if (response instanceof Error) throw response;

let { data } = response;

Expand All @@ -105,13 +106,17 @@ export const createClient = (config: Config = {}): Client => {
data: data ?? {},
};
} catch (error) {
const e = error as AxiosError;
if (opts.throwOnError) {
throw e;
throw error;
}
// @ts-expect-error
e.error = e.response?.data ?? {};
return e;

if (error instanceof AxiosError) {
// @ts-expect-error Property 'error' does not exist on type 'AxiosError<any, any>'.ts(2339)
error.error = error.response?.data ?? {};
return error;
}

return { error: {} };
}
};

Expand Down
21 changes: 13 additions & 8 deletions ...ests/main/test/__snapshots__/2.0.x/plugins/@tanstack/vue-query/axios/client/client.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// This file is auto-generated by @hey-api/openapi-ts

import type { AxiosError, AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios from 'axios';
import type { AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios, { AxiosError } from 'axios';

import { createSseClient } from '../core/serverSentEvents.gen';
import type { HttpMethod } from '../core/types.gen';
Expand Down Expand Up @@ -69,7 +69,7 @@ export const createClient = (config: Config = {}): Client => {
return { opts, url };
};

// @ts-expect-error
// @ts-expect-error is not assignable to type RequestResult
const request: Client['request'] = async (options) => {
// @ts-expect-error
const { opts, url } = await beforeRequest(options);
Expand All @@ -87,6 +87,7 @@ export const createClient = (config: Config = {}): Client => {
params: opts.paramsSerializer ? opts.query : undefined,
url,
});
if (response instanceof Error) throw response;

let { data } = response;

Expand All @@ -105,13 +106,17 @@ export const createClient = (config: Config = {}): Client => {
data: data ?? {},
};
} catch (error) {
const e = error as AxiosError;
if (opts.throwOnError) {
throw e;
throw error;
}
// @ts-expect-error
e.error = e.response?.data ?? {};
return e;

if (error instanceof AxiosError) {
// @ts-expect-error Property 'error' does not exist on type 'AxiosError<any, any>'.ts(2339)
error.error = error.response?.data ?? {};
return error;
}

return { error: {} };
}
};

Expand Down
21 changes: 13 additions & 8 deletions packages/openapi-ts-tests/main/test/__snapshots__/3.0.x/content-types/client/client.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// This file is auto-generated by @hey-api/openapi-ts

import type { AxiosError, AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios from 'axios';
import type { AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios, { AxiosError } from 'axios';

import { createSseClient } from '../core/serverSentEvents.gen';
import type { HttpMethod } from '../core/types.gen';
Expand Down Expand Up @@ -69,7 +69,7 @@ export const createClient = (config: Config = {}): Client => {
return { opts, url };
};

// @ts-expect-error
// @ts-expect-error is not assignable to type RequestResult
const request: Client['request'] = async (options) => {
// @ts-expect-error
const { opts, url } = await beforeRequest(options);
Expand All @@ -87,6 +87,7 @@ export const createClient = (config: Config = {}): Client => {
params: opts.paramsSerializer ? opts.query : undefined,
url,
});
if (response instanceof Error) throw response;

let { data } = response;

Expand All @@ -105,13 +106,17 @@ export const createClient = (config: Config = {}): Client => {
data: data ?? {},
};
} catch (error) {
const e = error as AxiosError;
if (opts.throwOnError) {
throw e;
throw error;
}
// @ts-expect-error
e.error = e.response?.data ?? {};
return e;

if (error instanceof AxiosError) {
// @ts-expect-error Property 'error' does not exist on type 'AxiosError<any, any>'.ts(2339)
error.error = error.response?.data ?? {};
return error;
}

return { error: {} };
}
};

Expand Down
21 changes: 13 additions & 8 deletions ...ts-tests/main/test/__snapshots__/3.0.x/parameter-explode-false-axios/client/client.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// This file is auto-generated by @hey-api/openapi-ts

import type { AxiosError, AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios from 'axios';
import type { AxiosInstance, RawAxiosRequestHeaders } from 'axios';
import axios, { AxiosError } from 'axios';

import { createSseClient } from '../core/serverSentEvents.gen';
import type { HttpMethod } from '../core/types.gen';
Expand Down Expand Up @@ -69,7 +69,7 @@ export const createClient = (config: Config = {}): Client => {
return { opts, url };
};

// @ts-expect-error
// @ts-expect-error is not assignable to type RequestResult
const request: Client['request'] = async (options) => {
// @ts-expect-error
const { opts, url } = await beforeRequest(options);
Expand All @@ -87,6 +87,7 @@ export const createClient = (config: Config = {}): Client => {
params: opts.paramsSerializer ? opts.query : undefined,
url,
});
if (response instanceof Error) throw response;

let { data } = response;

Expand All @@ -105,13 +106,17 @@ export const createClient = (config: Config = {}): Client => {
data: data ?? {},
};
} catch (error) {
const e = error as AxiosError;
if (opts.throwOnError) {
throw e;
throw error;
}
// @ts-expect-error
e.error = e.response?.data ?? {};
return e;

if (error instanceof AxiosError) {
// @ts-expect-error Property 'error' does not exist on type 'AxiosError<any, any>'.ts(2339)
error.error = error.response?.data ?? {};
return error;
}

return { error: {} };
}
};

Expand Down
Loading
Loading