refactor: remove custom skill install, delegate to vercel-labs/skills - #188
Closed
vanceingalls wants to merge 7 commits into
Closed
refactor: remove custom skill install, delegate to vercel-labs/skills#188vanceingalls wants to merge 7 commits into
vanceingalls wants to merge 7 commits into
Conversation
The single-quote replacement regex ran after key-quoting, causing it to match apostrophes inside already-double-quoted strings like "didn't". Moving it before key-quoting fixes the issue since it only matches actual single-quoted string values at that point. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove custom skill installation from the CLI in favor of vercel-labs/skills. Fixes staleness, deduplication, listing budget, and completeness issues identified by agentic harness pattern review. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
6 tasks: delete install-skills, strip skills from init, front-load SKILL.md descriptions, update CLAUDE.md, clean up my-video copies. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove installSkills(), getBundledSkillsDir(), project-level skill copying, and the --skip-skills flag. Replace post-scaffold messaging with directions to run `npx skills add heygen-com/hyperframes`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Also fix .claude/settings.json pre-commit hook to use bun instead of pnpm. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Resubmitting via Graphite stack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install-skills.ts(~485 lines) — custom skill installation wrapper and git fallback removed entirelyinit— no more project-level.claude/skills/copies, no--skip-skillsflag; replaced with post-scaffold message:npx skills add heygen-com/hyperframes.claude/settings.json— pre-commit hook changed frompnpmtobun(matching actual workspace tooling)Why
Reviewed the skill system against agentic harness patterns and found:
install-skills.tswas a thin wrapper aroundnpx skills addDelegating to the upstream skills CLI eliminates all four issues.
Test plan
npx tsx packages/cli/src/cli.ts skills→ "Unknown command skills"npx tsx packages/cli/src/cli.ts init test --template blank --non-interactive --skip-transcribe→ printsnpx skills add heygen-com/hyperframesin post-scaffold outputgrep -r "install-skills" packages/cli/src/→ no resultsskills/*/SKILL.mdhave front-loaded descriptions🤖 Generated with Claude Code