fix(skills): bootstrap npm safely on Windows - #2321
Closed
miguel-heygen wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Windows composition-authoring helpers can now bootstrap their optional HyperFrames dependency instead of failing before npm starts.
Why
On CLI v0.7.56 with Windows and Node 22.11,
animation-mapfailed withspawnSync npm.cmd EINVALwhile bootstrapping@hyperframes/producer@0.7.55. The core check and render paths remained healthy; only the optional helper was blocked.How
The animation and creative package loaders resolve npm's JavaScript CLI from
npm_execpathor the npm bundled besidenode.exe, then invoke it through Node with an argv array. This keepsshelldisabled, preserves--ignore-scriptsand temporary-prefix isolation, and leaves non-Windows npm execution unchanged.Test plan