Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/cli/src/utils/lintProject.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -951,6 +951,19 @@ describe("multiple_root_compositions", () => {
expect(finding).toBeUndefined();
});

it("ignores root-level rail.html generated for embedded-caption compositing", async () => {
const project = makeProject(validHtml());
writeFileSync(
join(project, "rail.html"),
'<div data-composition-id="rail" data-width="1080" data-height="1920" data-duration="10"></div>',
);
const { results } = await lintProject(project);
const finding = results[0]?.result.findings.find(
(f) => f.code === "multiple_root_compositions",
);
expect(finding).toBeUndefined();
});

it("ignores macOS AppleDouble HTML metadata files", async () => {
const project = makeProject(validHtml());
writeFileSync(join(project, "._index.html"), validHtml());
Expand Down
2 changes: 1 addition & 1 deletion packages/lint/src/project.ts
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ function lintMultipleRootCompositions(projectDir: string): HyperframeLintFinding
);
const rootCompositions: string[] = [];
for (const file of rootHtmlFiles) {
if (file === "caption-skin.html") continue;
if (file === "caption-skin.html" || file === "rail.html") continue;
const content = readFileSync(join(projectDir, file), "utf-8");
if (/data-composition-id/i.test(content)) {
rootCompositions.push(file);
Expand Down
Loading