docs(guides): resolve the Send-to fidelity contradiction (preserve substance, adapt form)#2620
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
… adapt form) The guide called the rebuild 'lossy by nature' while the checklist demanded 'content match the brief exactly', with no rule for what to preserve vs adapt. On a live import CD kept fonts/palette/hero but genericized the source's real figures (2.4M signals/sec, +240% spike) into vague phrases. Resolve around one principle: substance (real copy, exact palette/fonts, distinctive figures/data, product names, signature visuals) is preserved verbatim; only the form (static page to timed multi-scene motion) adapts.
a4e8184 to
03751cd
Compare
miguel-heygen
left a comment
There was a problem hiding this comment.
The instruction change is directionally strong: docs/guides/claude-design-send-to-hyperframes.md:89 makes the intended fidelity boundary concrete with real metrics and explicit anti-invention guidance, while lines 386 and 427 remove the old contradiction from the reference section and checklist.
blocker — docs/guides/claude-design-send-to-hyperframes.md:89: this is LLM-facing prompt text, but the PR adds no positive contract test for the new load-bearing instruction. Validate-docs proves syntax, not that a future edit cannot silently restore the exact failure this PR fixes. Add a focused guide-contract test that pins the concepts “Preserve substance; adapt form,” “do NOT genericize,” and “do NOT invent copy or numbers,” plus scoped negatives for the retired phrases “lossy by nature” and “content match the brief exactly.” This is the same prompt-regression discipline used on the related always-delivered import rules.
Verdict: REQUEST CHANGES
Reasoning: The wording resolves the fidelity contradiction, but the behavior remains unprotected against silent prompt regression until the new positive and retired-negative concepts are pinned.
— Magi
…sion Address review on #2620: the resolved 'preserve substance, adapt form' instruction is load-bearing LLM-facing prompt text, but validate-docs only proves syntax. Add a semantic pin (mirroring packages/cli figma skillContent.test.ts) asserting the three positive concepts are present and the two retired contradictory phrases ('lossy by nature', 'content match the brief exactly') cannot silently return.
miguel-heygen
left a comment
There was a problem hiding this comment.
Delta review on exact head ecc2626.
The substantive blocker is resolved: packages/cli/src/commands/claude-design/sendToGuideContract.test.ts pins all three requested positive concepts and scopes the two negatives to the retired contradictory phrases.
blocker — packages/cli/src/commands/claude-design/sendToGuideContract.test.ts:16: required CI is still red. Format fails because the GUIDE readFileSync call is not in oxfmt form; the formatter expands it to a multiline call with a trailing comma. That failure also makes two preflight jobs and preview-regression red, while the required Test job is still pending. Run the repository formatter, push the formatted result, and wait for required CI to pass before this can be approved.
Verdict: COMMENT
Reasoning: The requested semantic contract coverage is correct, but the current exact head cannot be approved while required formatting/preflight checks fail and Test remains pending.
— Magi
Wrap the readFileSync call to oxfmt form (printWidth 100); unblocks required Format + its preflight/preview-regression cascade on #2620.
miguel-heygen
left a comment
There was a problem hiding this comment.
Reviewed exact head b62bed5.
The final delta is the expected oxfmt-only expansion of the guide-contract readFileSync call. The LLM-facing fidelity rule now has focused positive pins for preserve/adapt, anti-genericization, and anti-invention, plus scoped negatives for both retired contradictory phrases. I rechecked the complete two-file diff and prior review history; there are no unresolved threads, the PR is mergeable, and every applicable check is green, including Format, all preflights, Test, CLI smoke, preview parity, regression shards, and Windows.
Verdict: APPROVE
Reasoning: Both prior blockers are resolved on the current head: the semantic contract is pinned and the test is formatter-clean, with all required and applicable CI green.
— Magi
Summary
The Send-to guide gave contradictory fidelity guidance: "Keep the original design as a reference" called the rebuild "lossy by nature" (content will be dropped), while the self-review checklist demanded "content match the brief exactly." Neither told Claude Design what to preserve versus adapt, so it genericized distinctive brand content.
Why it matters
On a live Send-to import, CD kept the exact fonts, palette, and hero headline but softened the source design's real figures (
2.4M signals/sec,+240% spike) into vague phrases ("streaming now"), losing the specificity that made the design feel live and real. The "lossy rebuild" framing licensed dropping content; the "match exactly" checklist was too absolute to be actionable.Fix
Resolve the tension around one principle, "preserve substance, adapt form":
Documentation only, no structural/contract changes.