This repository was archived by the owner on Jan 30, 2024. It is now read-only.
Add SignClient wrapper to manage WC sessions #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DAppConnector manages a list of signers to emit requested operations via Wallet Connect. Additionally, it simplifies the process of connecting, disconnecting, and restoring sessions by wrapping SignClient. DAppSigner is ready to send a request to the wallet for an operation. Currently, it supports two operations - 'signMessages' and 'signTransaction'. Added a new test to check the connection. It needs to be run with the --verbose option to be able to interact with the test (copy/paste the pairing string). The `test:connector` command for npm has been added.
hgraphql
approved these changes
Oct 24, 2023
| "@types/jest": "^29.5.3", | ||
| "@walletconnect/types": "^2.9.2", | ||
| "jest": "^29.6.2", | ||
| "lokijs": "^1.5.12", |
There was a problem hiding this comment.
it doesn't look like this is being used in this PR
There was a problem hiding this comment.
It is needed to run Wallet Connect libraries in NodeJS (to run tests). It is suggested by the WalletConnect package itself. Maybe we can remove this package as it has only added one simple test until we increase the number of tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DAppConnector manages a list of signers to emit requested operations via Wallet Connect. Additionally, it simplifies the process of connecting, disconnecting, and restoring sessions by wrapping SignClient.
DAppSigner is ready to send a request to the wallet for an operation. Currently, it supports two operations - 'signMessages' and 'signTransaction'.
Added a new test to check the connection. It needs to be run with the --verbose option to be able to interact with the test (copy/paste the pairing string). The
test:connectorcommand for npm has been added.