HHH-18898 fix of a NPE when using an embeddable with a specified JavaType #10235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2025
beikov
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
@JavaTypein an@Embeddableannotaded class, a NPE occurs when the field is used as a query parameter.The
AbstractSqlAstTranslatorevaluatesgetSqlTuple(comparisonPredicate.getRightHandExpression())to null when aSqmParameterInterpretationwith aJdbcParameterImplis given.Adding a null check resolves the problem.
The bug ticket only describes the NPE in
visitRelationalPredicate, but the same problem occurs invisitInListPredicate, so I added a fix for this too in this pull request.I would expect, that there are even more of similar queries where this can happen.
Further note: the bug was reported using a custom
@JavaTypebut the NPE is also thrown with native ones.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-18898