Fix HHH-19076 #10281
Open
Fix HHH-19076 #10281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
reviewed
Jun 4, 2025
...rnate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/JpaMetamodelImpl.java
Outdated
Show resolved
Hide resolved
This commit fixes HHH-19076. This bug is not trivial to reproduce since it requires a very specific entity setup: - There must be at least 2 entities - Both entities must extend the same @MappedSuperclass - The @MappedSuperclass must have an @id - One (and only one) of the entities must additionally use @IdClass - The entities must be named / loaded / etc. so that the entity WITHOUT the @IdClass is processed first Specifically the last step is impossible to reproduce reliably, since it depends on the [order hibernate processes the entities][1], which in turn depends on the order of the values of [a map `entityBindingMap`][2]. Depending on the order the entites are processed, the [`MetadataContext.mappedSuperClassTypeToPersistentClass`][3] map stores for the shared @MappedSuperclass a different entity. However, to correctly process the attributes of the @MappedSuperclass, the entity with the @IdClass must be used in [`resolveVirtualIdentifierMember`][4]. To fix this, this commit changes the simple [`mappedSuperClassTypeToPersistentClass`][3] map to store a set of entities instead of only the first encountered entity. Next, the [`resolveVirtualIdentifierMember`][4] function uses the first matching entity of this set. [1]: https://github.com/hibernate/hibernate-orm/blob/3cfeb8fa29769258a0c0615b7e14b469798f0f3a/hibernate-core/src/main/java/org/hibernate/metamodel/model/domain/internal/JpaMetamodelImpl.java#L627-L629 [2]: https://github.com/hibernate/hibernate-orm/blob/3cfeb8fa29769258a0c0615b7e14b469798f0f3a/hibernate-core/src/main/java/org/hibernate/boot/internal/MetadataImpl.java#L86 [3]: https://github.com/hibernate/hibernate-orm/blob/3cfeb8fa29769258a0c0615b7e14b469798f0f3a/hibernate-core/src/main/java/org/hibernate/metamodel/internal/MetadataContext.java#L96 [4]: https://github.com/hibernate/hibernate-orm/blob/3cfeb8fa29769258a0c0615b7e14b469798f0f3a/hibernate-core/src/main/java/org/hibernate/metamodel/internal/AttributeFactory.java#L687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes HHH-19076. This bug is not trivial to reproduce since it requires a very specific entity setup:
@MappedSuperclass@MappedSuperclassmust have an@Id@IdClass@IdClassis processed firstSpecifically the last step is impossible to reproduce reliably, since it depends on the order hibernate processes the entities, which in turn depends on the order of the values of a map
entityBindingMap.Depending on the order the entities are processed, the
MetadataContext.mappedSuperClassTypeToPersistentClassmap stores for the shared@MappedSuperclassa different entity.However, to correctly process the attributes of the
@MappedSuperclass, the entity with the@IdClassmust be used inresolveVirtualIdentifierMember.To fix this, this commit changes the simple
mappedSuperClassTypeToPersistentClassmap to store a setof entities instead of only the first encountered entity.
Next, the
resolveVirtualIdentifierMemberfunction uses the first matching entity of this set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19076