Skip to content

Conversation

@peter1123581321
Copy link
Contributor

@peter1123581321 peter1123581321 commented Jun 17, 2025

In HHH-14584, an additional field was requested in Identifier to indicate explicit namings of columns.
This would allow more possibilies in a custom PhysicalNamingStrategy.

As PhysicalNamingStrategy also provides methods for sequences and tables, this PR also implements handling explicit namings of both of them.
However, I did not provide it for schemas and catalogs.

Many thanks in advance for feedback, comments and change requests. :)


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-14584

@peter1123581321 peter1123581321 marked this pull request as draft June 18, 2025 16:11
@peter1123581321 peter1123581321 marked this pull request as draft June 18, 2025 16:11
@peter1123581321 peter1123581321 marked this pull request as ready for review June 19, 2025 06:31
@yrodiere
Copy link
Member

yrodiere commented Oct 6, 2025

Hey @peter1123581321 , it looks like your PR isn't passing tests on all DBs. Also, since it's been a while (sorry) it's now conflicting with the main branch.

Could you please rebase, force push, and have a look at test results to see what needs fixing?

@peter1123581321
Copy link
Contributor Author

@yrodiere Thanks for the reminder. Unfortunately, I haven't had any time lately. I've just rebased the branch and will have a look on the failed tests in the following days. :-)

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! A few comments below, though we mostly need to determine if the CI failures are real or not.

@peter1123581321
Copy link
Contributor Author

@yrodiere thanks for the hint conerning getSequenceNextValString, everything's green now :-)

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I allowed Jenkins CI to start. Let's merge once that one is green!

@yrodiere yrodiere merged commit 31ce5d3 into hibernate:main Nov 18, 2025
27 of 28 checks passed
@yrodiere
Copy link
Member

We may have to delay this after all, because main is currently 7.2 in CR phase. See #11285 . But if we do, I will open a new PR with the same changeset, to be merged once main becomes 7.3.

@yrodiere
Copy link
Member

New PR: #11297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants