-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
HHH-14584 Allow PhysicalNamingStrategy implementations to detect when a name is implicit or explicit #10366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hibernate-core/src/main/java/org/hibernate/boot/internal/InFlightMetadataCollectorImpl.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/internal/AnnotatedColumn.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/internal/EntityBinder.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/naming/Identifier.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/id/enhanced/SequenceStyleGenerator.java
Outdated
Show resolved
Hide resolved
f3a867d to
f2c18e7
Compare
|
Hey @peter1123581321 , it looks like your PR isn't passing tests on all DBs. Also, since it's been a while (sorry) it's now conflicting with the Could you please rebase, force push, and have a look at test results to see what needs fixing? |
f2c18e7 to
8978363
Compare
|
@yrodiere Thanks for the reminder. Unfortunately, I haven't had any time lately. I've just rebased the branch and will have a look on the failed tests in the following days. :-) |
… a name is implicit or explicit
8978363 to
afa1276
Compare
yrodiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! A few comments below, though we mostly need to determine if the CI failures are real or not.
hibernate-core/src/test/java/org/hibernate/orm/test/associations/ExplicitIdentifierTest.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/test/java/org/hibernate/orm/test/associations/ExplicitIdentifierTest.java
Show resolved
Hide resolved
… a name is implicit or explicit
|
@yrodiere thanks for the hint conerning |
yrodiere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I allowed Jenkins CI to start. Let's merge once that one is green!
hibernate-core/src/test/java/org/hibernate/orm/test/associations/ExplicitIdentifierTest.java
Show resolved
Hide resolved
|
We may have to delay this after all, because |
|
New PR: #11297 |
In HHH-14584, an additional field was requested in
Identifierto indicate explicit namings of columns.This would allow more possibilies in a custom
PhysicalNamingStrategy.As
PhysicalNamingStrategyalso provides methods for sequences and tables, this PR also implements handling explicit namings of both of them.However, I did not provide it for schemas and catalogs.
Many thanks in advance for feedback, comments and change requests. :)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-14584