HHH-19941 simplify Session.contains() #11276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have no clue what the call to delayedAfterCompletion() was doing here, but I don't see how it could possibly be correct.
and introduce SharedSessionContractImplementor.isManaged()
gavinking
changed the title
sebersole
reviewed
Nov 18, 2025
Member
sebersole
left a comment
sebersole
left a comment
There was a problem hiding this comment.
Jira issue please, otherwise lgtm
Member
Perhaps, but as a general rule we put that on all API methods |
Member
Author
The issue is HHH-19941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems to me that
delayedAfterCompletion()here is unnecessary, but perhaps I'm wrong.WDYT, @sebersole?
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19941