[wip/4.2] Implemented Reactive versions of PostAction, PreAction and JdbcSelectWithActions #2732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hibernate-github-bot
bot
changed the title
hibernate-github-bot
bot
added
the
wip/4.2
DavideD
reviewed
Nov 4, 2025
| public String name; | ||
|
|
||
| @ManyToOne | ||
| @ManyToOne(fetch = FetchType.LAZY) |
Member
There was a problem hiding this comment.
I don't think you should change the mapping of an existing test. ALso, does it matter if you use lazy here?
Member
Author
There was a problem hiding this comment.
With the new Lock implementation in ORM, it affects the number of queries executed.
I'm going to revert this change and modify the testFindUpgradeNoWait assertions accrdingly
…ction` and `JdbcSelectWithActions`
dreab8
force-pushed
the
issue#2651_4.2
branch
3 times, most recently
from
4189a5f to
229542e
Compare
dreab8
force-pushed
the
issue#2651_4.2
branch
from
229542e to
a48c3b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2651
The PR implements the Reactive version of
JdbcSelectWithActionsand of the newPostActionandPreAction(ReactiveLockTimeoutHandlerandReactiveLockTimeoutHandler).The PR does not implement the Reactive version of
CollectionLockingActionbut in order to use it a Reactive version oforg.hibernate.query.SelectionQuery#setLockScope(Locking.Scope lockScope);method need to be added.