-
Notifications
You must be signed in to change notification settings - Fork 6
feat: changed container work dir from app to opt #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: changed container work dir from app to opt #872
Conversation
6becdd1
to
a8d6815
Compare
...e/src/test/java/org/hiero/block/server/persistence/storage/PersistenceStorageConfigTest.java
Outdated
Show resolved
Hide resolved
955c213
to
0ee82c3
Compare
@jsync-swirlds @Nana-EC Thank you for the guidance and the reviews. Your help is much appreciated. I am still trying to complete the testing of the Helm chart changes, but I am having some difficulties running the pods with local Docker images (containing the Dockerfile changes) instead of the ones from the registry. Perhaps someone more proficient with Kubernetes than I am could check whether the changes are valid or if a new issue related to the K8s part should be opened. |
Perhaps @AlfredoG87 could take a look once the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few PRs (this included) will likely be delayed and impacted by significant ongoing rewrites of the code base.
I'm blocking the PR for now just to avoid any unintended conflicts and to save you effort.
Once things are in the clear we can decide whether to rebase (if all changes are still applicable), pull some changes into a new PR (in a subset is still applicable) or if to close this underlying ticket if it's no longer applicable.
Thanks for your interest and contributions here, we'll be laying out more tickets that the community can look to to pick up and also exploring how to have community calls to improve the efficiency and sharing of information.
Hey @AlexKehayov , feel free to rebase and update if you're able to now that the refactor to |
Signed-off-by: Alex Kehayov <[email protected]>
0ee82c3
to
d1add33
Compare
@Nana-EC, the conflicts are resolved :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #872 +/- ##
=========================================
Coverage 82.07% 82.07%
Complexity 858 858
=========================================
Files 102 102
Lines 3694 3694
Branches 380 380
=========================================
Hits 3032 3032
Misses 525 525
Partials 137 137
🚀 New features to boost your workflow:
|
Reviewer Notes
Replaced /app with /opt in the server's Docker and Helm chart configurations, as well as in the simulator's Dockerfile.
Tested local run and Docker run for the server and the simulator.
Tested K8 run for the server.
P.S.
I was unable to test the simulator in K8 due to difficulties connecting it to a running BN server, likely because of a misunderstanding of the configuration steps on my part. While the simulator runs fine in a Docker container and chart changes were not applied, it would still be good to be tested.
A thorough review of these changes, especially regarding the K8 integration, would be greatly appreciated.
Related Issue(s)
Closes #684