Skip to content

fix: 19424: Backport the fix for 19319 to release 0.62 #19444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release/0.62
Choose a base branch
from

Conversation

artemananiev
Copy link
Contributor

Fix summary: changes for #19319 and related fixes are backported to the release/0.62 branch.

! There are no plans to merge this to release/0.62 yet. However, I'd like to have this PR ready, in case issues described in the original ticket are observed in real networks.

Fixes: #19424
Signed-off-by: Artem Ananev [email protected]

@artemananiev artemananiev added this to the v0.62 milestone May 29, 2025
@artemananiev artemananiev self-assigned this May 29, 2025
@artemananiev artemananiev requested a review from a team as a code owner May 29, 2025 19:37
@artemananiev artemananiev added Platform Virtual Map Platform Data Structures Platform Tickets pertaining to the platform Stability Tickets pertaining to the stability of the consensus node. labels May 29, 2025
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.04% (target: -1.00%) 47.86%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (23a4c50) 100155 73536 73.42%
Head commit (527f570) 100163 (+8) 73506 (-30) 73.39% (-0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#19444) 117 56 47.86%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 42.73504% with 67 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../com/swirlds/merkledb/files/DataFileCompactor.java 8.33% 44 Missing ⚠️
...wirlds/merkledb/MerkleDbCompactionCoordinator.java 55.17% 7 Missing and 6 partials ⚠️
.../java/com/swirlds/merkledb/MerkleDbDataSource.java 73.52% 9 Missing ⚠️
...swirlds/merkledb/collections/AbstractLongList.java 83.33% 1 Missing ⚠️

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.62   #19444      +/-   ##
==================================================
- Coverage           69.44%   69.41%   -0.03%     
+ Complexity          23177    23172       -5     
==================================================
  Files                2629     2629              
  Lines              100250   100258       +8     
  Branches            10369    10364       -5     
==================================================
- Hits                69615    69597      -18     
- Misses              26666    26704      +38     
+ Partials             3969     3957      -12     
Files with missing lines Coverage Δ Complexity Δ
...swirlds/merkledb/collections/AbstractLongList.java 88.32% <83.33%> (+0.13%) 80.00 <1.00> (+4.00)
.../java/com/swirlds/merkledb/MerkleDbDataSource.java 69.45% <73.52%> (-0.03%) 99.00 <3.00> (+3.00) ⬇️
...wirlds/merkledb/MerkleDbCompactionCoordinator.java 69.56% <55.17%> (-10.44%) 11.00 <8.00> (-8.00)
.../com/swirlds/merkledb/files/DataFileCompactor.java 26.55% <8.33%> (-3.45%) 15.00 <1.00> (-2.00)

... and 17 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@artemananiev artemananiev linked an issue May 29, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Data Structures Platform Virtual Map Platform Tickets pertaining to the platform Stability Tickets pertaining to the stability of the consensus node.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backport the fix for 19319 to release 0.62
1 participant