chore(WIP): Deprecate EthereumFlow and introduce Jumbo Transaction testing #984
+273
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: gsstoykov <[email protected]>
gsstoykov
changed the title
rwalworth
reviewed
Jul 31, 2025
|
|
||
| // Convert r and s to BIGNUM | ||
| BIGNUM* r = BN_bin2bn(reinterpret_cast<const unsigned char*>(rBytes.data()), 32, nullptr); | ||
| BIGNUM* s = BN_bin2bn(reinterpret_cast<const unsigned char*>(sBytes.data()), 32, nullptr); |
Contributor
There was a problem hiding this comment.
Just FYI there are some objects in impl/openssl_utils that take care of the garbage collection for these OpenSSL types. You can either use the ones there or add more to simplify the processing here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Deprecate EthereumFlow and test Jumbo Transactions.
Related issue(s):
Fixes #912
Notes for reviewer:
Still need to test Jumbo Transactions so WIP.
Checklist