ci: add standalone workflow to enforce test naming rules (Fixes #744)

Signed-off-by: Raja Rathour <[email protected]>

Author: Raja-89

.github/workflows/pr-check-naming-test.yml

@@ -0,0 +1,62 @@
+name: "Test File Naming Check"
+
+on:
+  pull_request:
+    types: [opened, reopened, synchronize, edited]
+
+permissions:
+  contents: read
+
+concurrency:
+  group: test-name-check-${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  test-name-check:
+    name: Test File Naming Check
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Harden the runner (Audit all outbound calls)
+        uses: step-security/harden-runner@ec9f2d5744a09debf3a187a3f4f675c53b671911 # v2.13.0
+        with:
+          egress-policy: audit
+
+      # Using the specific commit SHA for actions/[email protected], as requested
+      - name: Checkout repository
+        uses: actions/checkout@8ade135a368bb9860e15bcafd2cf940ba6f36c4c
+
+      - name: Validate test file naming convention
+        run: |
+          echo "🔍 Checking test file naming rules..."
+          
+          # Helper files that must be excluded from naming validation
+          EXCLUDES="__init__.py conftest.py mock_server.py utils_for_test.py"
+
+          # Build exclude arguments for find
+          EX_ARGS=""
+          for f in $EXCLUDES; do
+            EX_ARGS="$EX_ARGS ! -name \"$f\""
+          done
+
+          # Rule 1 — Unit tests (tests/unit) must start with test_*.py
+          echo "➡️ Checking UNIT tests (must start with test_)..."
+          invalid_unit=$(eval "find tests/unit -type f -name '*.py' $EX_ARGS ! -name 'test_*.py'")
+
+          # Rule 2 — Integration tests (tests/integration) must end with *_test.py
+          echo "➡️ Checking INTEGRATION tests (must end with _test.py)..."
+          invalid_integration=$(eval "find tests/integration -type f -name '*.py' $EX_ARGS ! -name '*_test.py'")
+
+          if [ -n "$invalid_unit" ]; then
+            echo "❌ Invalid Unit Test Filenames:"
+            echo "$invalid_unit"
+            exit 1
+          fi
+
+          if [ -n "$invalid_integration" ]; then
+            echo "❌ Invalid Integration Test Filenames:"
+            echo "$invalid_integration"
+            exit 1
+          fi
+
+          echo "✅ All test files follow the correct conventions!"

.github/workflows/pr-checks.yml

@@ -70,28 +70,24 @@ jobs:
 
           echo "Checking files changed in PR #${PR_NUMBER}..."
 
-          # List files in the PR and check for CHANGELOG.md (root or any path ending with /CHANGELOG.md)
           FILES_JSON="$(gh api repos/${{ github.repository }}/pulls/${PR_NUMBER}/files --paginate)"
           if ! echo "${FILES_JSON}" | jq -e '.[] | select(.filename | test("(^|/)CHANGELOG\\.md$"; "i"))' >/dev/null; then
             echo "FAIL: CHANGELOG.md was not changed in this PR."
             exit 1
           fi
 
-          # Ensure there is at least one line-level change (+ or -) in the patch for CHANGELOG.md
           PATCH_CONTENT="$(echo "${FILES_JSON}" \
             | jq -r '.[] | select(.filename | test("(^|/)CHANGELOG\\.md$"; "i")) | .patch // empty')"
 
-          # If no patch is returned (very large file or API omission), treat presence as sufficient
           if [[ -z "${PATCH_CONTENT}" ]]; then
-            echo "CHANGELOG.md modified (no patch provided by API). Passing."
+            echo "CHANGELOG.md modified (patch omitted). Passing."
             exit 0
           fi
 
-          # Look for actual line changes (exclude diff headers +++/---)
           if echo "${PATCH_CONTENT}" | awk '{print $0}' | grep -E '^[+-]' | grep -vE '^\+\+\+|^\-\-\-' >/dev/null; then
             echo "PASS: CHANGELOG.md contains line-level changes."
             exit 0
           else
             echo "FAIL: No line-level changes detected in CHANGELOG.md."
             exit 1
-          fi
+          fi

CHANGELOG.md

@@ -7,6 +7,7 @@ This changelog is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.
 ## [Unreleased]
 
 ### Added
+- CI: Add standalone workflow `pr-check-naming-test.yml` to validate test filenames. Enforces unit tests begin with `test_` and integration tests end with `_test.py`, with exclusions for helper files. (Fixes #744)
 - Add `TokenFeeScheduleUpdateTransaction` class to support updating custom fee schedules on tokens (#471).
 - Add `examples/token_update_fee_schedule_fungible.py` and `examples/token_update_fee_schedule_nft.py` demonstrating the use of `TokenFeeScheduleUpdateTransaction`.
 - Update `docs/sdk_users/running_examples.md` to include `TokenFeeScheduleUpdateTransaction`.