fix: Prevent proto package recompiling on every build #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

tr11 wants to merge 116 commits into hiero-ledger:main from tr11:fix-proto-recompiling

tr11 commented May 3, 2025

Description:
Prevent the hedera and hedera-proto packages from recompiling on every built of dependent crates.

Related issue(s): None

Fixes #

Currently the proto package will trigger a recompilation of both hedera and hedera-proto packages even if nothing changed in the protobufs folder. This PR changes the emit_rerun_if_changed behavior before compiling the modified proto files from services folder to ensure reruns only trigger when there are modifications.

Notes for reviewer:

Test by compiling twice any crate dependent on this package.

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

tr11 requested review from a team as code owners

May 3, 2025 16:03

tr11 requested review from RickyLB and Sheng-Long

May 3, 2025 16:03

Contributor

gsstoykov commented May 9, 2025

@tr11 Thanks for the contribution! DCO checks will fail when commits are not signed. Take a look at https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-gpg-key

tr11 force-pushed the fix-proto-recompiling branch 3 times, most recently from 13639aa to 6f033d5 Compare

May 9, 2025 22:28

tr11 force-pushed the fix-proto-recompiling branch from fedcef3 to 1884cee Compare

June 27, 2025 01:31

Contributor

mehcode commented Aug 9, 2025 •

edited

Loading

Can we please get this merged?

And if there is anyway to add a test to ensure this behavior isn't broken, can we please do that as well. Our team fixed this last year ( #864 ) but it broke a few months later and we haven't had the chance to fix it again. Thanks @tr11.

Contributor

gsstoykov commented Aug 15, 2025

@mehcode @tr11 PR needs to be formatted. Will try to get this in ASAP.

tr11 changed the title ~~Prevent proto package recompiling on every build~~ fix: Prevent proto package recompiling on every build

Author

tr11 commented Sep 5, 2025

Formatting updated and rebased to the 0.40 version.

dependabot bot and others added 17 commits

September 11, 2025 07:49


          chore(deps): bump step-security/harden-runner from 2.11.1 to 2.12.0 (h…

89ce4d8

…iero-ledger#938)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>


          Prevent proto package from recompiling on every build.

3e39688

Signed-off-by: Tiago Requeijo <[email protected]>


          Make sure the sdk folder is checked

28c7e3b

Signed-off-by: Tiago Requeijo <[email protected]>


          Create MAINTAINERS.md (hiero-ledger#915)

dfe4ca8

Signed-off-by: Hendrik Ebbers <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump openssl from 0.10.70 to 0.10.72 (hiero-ledger#920)

fb05056

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump async-trait from 0.1.81 to 0.1.88 (hiero-ledger#925)

ae407b0

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ricky Saechao <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump prost from 0.13.4 to 0.13.5 (hiero-ledger#926)

508e3fa

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump anyhow from 1.0.86 to 1.0.98 (hiero-ledger#935)

debc386

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump hex-literal from 0.4.1 to 1.0.0 (hiero-ledger#936)

2628afc

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          Add exchange_rate_in_cents to ExchangeRate (hiero-ledger#875)

0579a72

Signed-off-by: Ricky Saechao <[email protected]>
Co-authored-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump expect-test from 1.5.0 to 1.5.1 (hiero-ledger#943)

418ba6b

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump pem from 3.0.4 to 3.0.5 (hiero-ledger#944)

9ab0d9c

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump k256 from 0.13.3 to 0.13.4 (hiero-ledger#945)

ffc03fc

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>


          feat: Add auto set for auto_renew_account (hiero-ledger#907)

0939e76

Signed-off-by: gsstoykov <[email protected]>
Co-authored-by: Ricky Saechao <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump rlp from 0.5.2 to 0.6.1 (hiero-ledger#947)

5e0b2a1

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          release: v0.33.0 (hiero-ledger#951)

97f4354

Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump hyper from 0.14.30 to 1.6.0 (hiero-ledger#952)

4e085cd

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>

gsstoykov and others added 27 commits

September 11, 2025 07:49


          fix: Disable e2e tests (hiero-ledger#1063)

aaa0b2d

Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          release: v0.38.1 (hiero-ledger#1064)

89dc019

Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore: Fix minor issue with DUAL_PUBLISH_ENABLED environment variable…

b64c2af

… definition (hiero-ledger#1066)

Signed-off-by: Roger Barker <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          ci: Add Package Version Summary to zxf-publish-release.yaml (hiero-le…

0cf678d

…dger#1068)

Signed-off-by: Roger Barker <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          ci: Fix typos in Package Version Summary (hiero-ledger#1069)

cf92396

Signed-off-by: Roger Barker <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          feat: Introduce delete GRPC Web proxies (hiero-ledger#1071)

5f26107

Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump h2 from 0.4.11 to 0.4.12 (hiero-ledger#1075)

6a9065b

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump step-security/conventional-pr-title-action from 3.2…

7239db6

….1 to 3.2.3 (hiero-ledger#1077)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump actions/checkout from 4.2.2 to 4.3.0 (hiero-ledger#…

a4de911

…1072)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump slab from 0.4.10 to 0.4.11 (hiero-ledger#1079)

d1cd4ab

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>


          feat(HIP-551): Introduce BatchTransactions (hiero-ledger#1078)

f8656cb

Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          fix: refer signed sources (hiero-ledger#1080)

038c409

Signed-off-by: venilinvasilev <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump clap from 4.5.42 to 4.5.45 (hiero-ledger#1082)

d07f466

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump async-trait from 0.1.88 to 0.1.89 (hiero-ledger#1083)

a8aada3

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump thiserror from 1.0.69 to 2.0.15 (hiero-ledger#1086)

7bc2588

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump anyhow from 1.0.98 to 1.0.99 (hiero-ledger#1084)

fdce6c5

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(release): v0.39.0 (hiero-ledger#1087)

7ce2c8d

Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump actions/checkout from 4.3.0 to 5.0.0 (hiero-ledger#…

b8c11d5

…1081)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(release): v0.39.1 (hiero-ledger#1088)

c17e6db

Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          fix: Release CN version (hiero-ledger#1089)

5f0dafb

Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(release): v0.39.2 (hiero-ledger#1090)

dbb8f46

Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          feat: Introduce Schedule Transaction fee limits tests (hiero-ledger#1093

33d9024

)

Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump regex from 1.11.1 to 1.11.2 (hiero-ledger#1092)

d656add

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore(deps): bump tracing-subscriber from 0.3.19 to 0.3.20 (hiero-led…

8edc9aa

…ger#1094)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tiago Requeijo <[email protected]>


          chore: Release v0.40.0 (hiero-ledger#1095)

62940a3

Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          fix: Replace solo quick-start with solo-action (hiero-ledger#1097)

Signed-off-by: gsstoykov <[email protected]>
Signed-off-by: Tiago Requeijo <[email protected]>


          Fixed formatting

7600f80

Signed-off-by: Tiago Requeijo <[email protected]>

tr11 force-pushed the fix-proto-recompiling branch from 9956ac7 to 7600f80 Compare

September 11, 2025 11:49

tr11 requested a review from a team as a code owner

September 11, 2025 11:49

tr11 requested a review from PavelSBorisov

September 11, 2025 11:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Sheng-Long Awaiting requested review from Sheng-Long Sheng-Long is a code owner automatically assigned from hiero-ledger/hiero-sdk-rust-maintainers

RickyLB Awaiting requested review from RickyLB RickyLB is a code owner automatically assigned from hiero-ledger/hiero-sdk-rust-committers

PavelSBorisov Awaiting requested review from PavelSBorisov PavelSBorisov is a code owner automatically assigned from hiero-ledger/github-maintainers

At least 1 approving review is required to merge this pull request.

Labels

None yet