Fix long-press copy to include nested list options by copying visible list item text#36
Closed
Fix long-press copy to include nested list options by copying visible list item text#36
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Copilot
AI
changed the title
[WIP] Fix long-press copy to include nested list options by copying visible list item text
Fix long-press copy to include nested list options by copying visible list item text
Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The long-press copy functionality for list items was using a brittle index-based lookup that caused issues with nested lists. The system relied on:
window.__APP_DATA__.listItemsarray (parsed markdown items)data-list-indexattributes assigned to each<li>elementThis created a mismatch between the parsed markdown structure and the actual DOM NodeList, especially when questions contained nested options. As a result:
Solution
Replaced the index-based approach with direct element text copying using
element.innerTextorelement.textContent. This approach:<li>elementChanges
Before:
After:
Files Modified
js/client-modules/list-item-controller.js- Updated main copy logicjs/rendered-page-builder.js- Applied same fix to inlined controller for rendered pagesTesting
Tested with markdown content containing numbered questions with nested bullet point options (like math homework problems). The fix ensures that long-pressing a question copies both the question text and all its nested options.
Backwards Compatibility
ENABLE_LIST_LONG_PRESS_COPYand UI toggle remain unchangedCreated from VS Code via the GitHub Pull Request extension.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.