docs(skill): /trade setup tracks the knowledge dir by default, drops the global gitignore entry; release v2.17.0

[himself65]

What

Replaces the git handling in /trade setup step 4 with one model that matches the rest of the skill: the personal knowledge dir is private and version-tracked by default. Setup ignores it only where it would otherwise be committed to the wrong repo, and never writes the global gitignore. The scaffolded template's "Git tracking" section now describes the same model. Bumps the plugin to v2.17.0 (plugin.json + both marketplace.json fields), so merging auto-tags and releases.

Why

Step 4 unconditionally appended an unanchored knowledge/ to the user's global gitignore, and the same pattern to the .gitignore of whatever repo setup ran in, on the premise that the knowledge dir "stays local". The rest of the skill says the opposite:

• SKILL.md → Knowledge Architecture: L2 is "private, usually a separate repo found via knowledge_path".
• commands/import.md: "Do not commit — the personal knowledge repo is version-tracked on purpose".
• data-collection.md: a repo's visibility is set by the most restrictive corpus it holds, a rule that only matters for a tracked repo.

The failure is silent (reproduced in a scratch repo). With the global line present, a notes repo keeps showing edits to files it already tracks, but a new writedown never appears in git status and git add -A skips it. Only an explicit git add <path> complains. So a notes repo that keeps its bundle in a knowledge/ subdirectory (e.g. ~/Code/<site>/knowledge/, resolved via knowledge_path) looks healthy while new notes never reach a commit. Two more problems:

• The unanchored pattern also hid every knowledge/ directory in every other repo on the machine.
• The project-level entry resolved the repo from the cwd rather than from the target, so a target in another repo got a path relative to the wrong repo.

How setup behaves now (step 4)

Setup finds the repo that contains the target (git -C <target> rev-parse --show-toplevel) and asks which case applies instead of inferring it:

Host repo	Setup
None	Writes nothing. Suggests git init plus a private remote.
Meant to hold the notes	Writes nothing, then runs git check-ignore -v --no-index on the scaffolded files to confirm no rule hides them (without --no-index, tracked files are skipped). Warns if the remote is public.
Not meant to hold them (a code repo, a public repo, a clone of this plugin)	Adds an anchored /<path>/ entry to that clone's .git/info/exclude, which is never committed and is shared by linked worktrees. Skips the write if a rule already covers the dir, and warns if notes are already tracked there.

• Setup never writes the global gitignore and never modifies git config.
• It offers, and asks before acting, to delete the entries older versions wrote under their # Personal trade knowledge scaffolded by /trade setup — never commit. comment.
• Step 1 now warns when the cwd is a code repo, because the default ./knowledge would then land inside it.

Files

• references/commands/setup.md: step 1 note, step 4 rewritten (4a–4d), constraints.
• references/commands/templates/knowledge-index.md: "Git tracking" and "Re-running setup" rewritten. The stale knowledge/*/raw/ tip becomes the corpus rule: a large corpus goes to its own repo via $TRADE_CORPUS_DIR. The intro now says posts can arrive as links, matching docs(skill): prompt audit for Claude Opus 5.5 — fix accreted contradictions, de-shout gates; release v2.16.0 #53's step 1.
• references/log.md: dated entry above docs(skill): prompt audit for Claude Opus 5.5 — fix accreted contradictions, de-shout gates; release v2.16.0 #53's.
• plugins/trade/plugin.json, .claude-plugin/marketplace.json: 2.16.0 → 2.17.0.

Reviewer notes

• Merged with docs(skill): prompt audit for Claude Opus 5.5 — fix accreted contradictions, de-shout gates; release v2.16.0 #53. docs(skill): prompt audit for Claude Opus 5.5 — fix accreted contradictions, de-shout gates; release v2.16.0 #53 landed while this branch was open. It shipped v2.16.0 and fixed the same raw/ leftovers in setup step 5 and in the template's ingestion steps and layout table. The conflicting hunks take docs(skill): prompt audit for Claude Opus 5.5 — fix accreted contradictions, de-shout gates; release v2.16.0 #53's wording, which matches its import.md change (copy the source into a corpus, leave the original). This PR's diff is therefore only the git model, and the version moves to 2.17.0.
• Every git command in the new steps was run in a scratch repo: the absolute --git-path info/exclude from a subdirectory and from a linked worktree, check-ignore -q / -v --no-index on tracked, untracked and not-yet-existing paths, and anchored vs unanchored matching.
• claude plugin validate --strict passes for the plugin and the marketplace, relative links in the edited files resolve, and the version matches in all three places. skill-lint runs only in CI and was not run locally.
• This repo's own .gitignore entry for knowledge/ is unchanged. It is the right protection for clones of this public repo, and step 4b's dedupe check detects it.
• Existing users' scaffolded index.md is not rewritten, because setup never overwrites files. Step 4d's cleanup is how an old global entry gets removed.