Fix connection #29
Fix connection #29
Conversation
…tead of create a connection per sharded model
| let(:connection_names) { ["primary", "ShardForTestUser001", "ShardForTestUser002", "ShardForTestUser003", "SequencerForTestUserSequencer"] } | ||
|
|
||
| it "Create 1 connection for each DB" do | ||
| expect(ActiveRecord::Base.connection_handler.connection_pool_list.map{|c| c.spec.name }).to match_array(connection_names) |
There was a problem hiding this comment.
Layout/SpaceBeforeBlockBraces: Space missing to the left of {.
Layout/SpaceInsideBlockBraces: Space between { and | missing.
| @@ -35,6 +37,14 @@ def find_from_all_by_name(name) | |||
|
|
|||
| let(:alice) { model.put! name: "Alice" } | |||
|
|
|||
| context "ActiveRecord::ConnectionAdapters::ConnectionPool" do | |||
| let(:connection_names) { ["primary", "ShardForTestUser001", "ShardForTestUser002", "ShardForTestUser003", "SequencerForTestUserSequencer"] } | |||
There was a problem hiding this comment.
Style/WordArray: Use %w or %W for an array of words.
| end | ||
| a_class.class_eval { abstract_class = true } |
There was a problem hiding this comment.
Lint/UselessAssignment: Useless assignment to variable - abstract_class.
| @@ -1,3 +1,14 @@ | |||
| module EstablishConnectionForShard | |||
There was a problem hiding this comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
|
Thank you for feedback. I want to think for redesign modules. |
|
Thank you for review. |
establish_connectionstore the connection to ConnectionPool with name of called class name.So, original code was creating connections for each sharded model.
I fixed that use same ConnectionPool for same DB.
This fix decrease connection count to the DB.