- 
                Notifications
    You must be signed in to change notification settings 
- Fork 312
refactor!: update clarity representation #1646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| The latest updates on your projects. Learn more about Vercel for Git ↗︎ 
 | 
| Codecov ReportAttention: Patch coverage is  
 
 Additional details and impacted files@@            Coverage Diff             @@
##             next    #1646      +/-   ##
==========================================
- Coverage   66.37%   66.28%   -0.09%     
==========================================
  Files         119      124       +5     
  Lines        8717     8676      -41     
  Branches     1920     1894      -26     
==========================================
- Hits         5786     5751      -35     
+ Misses       2806     2803       -3     
+ Partials      125      122       -3     ☔ View full report in Codecov by Sentry. | 
472091f    to
    875da4a      
    Compare
  
    875da4a    to
    295512c      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
3ec88d6    to
    4567898      
    Compare
  
    BREAKING CHANGE: The `ClarityType` was changed to a readable string, from the previous Number type. This makes it easier to read and construct types when debugging.
e279ac3    to
    6ddc393      
    Compare
  
    
buildUpdate commitlint config to allow longer lines (e.g. when adding
BREAKING CHANGEbody to commit message.refactor!Introduce a new ClarityWireType to replace the existing ClarityType, which now is human-readable.
This is done in anticipation of stacksgov/sips#166
Next steps
In a future PR, I may update the
.buffer, .valueetc. to all follow a similar pattern (e.g. to all be.value)