Skip to content

📖 scanner: mark agent env residual lane open #4847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clubanderson merged 1 commit into from
Aug 27, 2026
Merged

📖 scanner: mark agent env residual lane open #4847

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bin/agent-env-scrub.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@
# - git-credential-hive.sh reads the per-agent cache file directly; hive-merge
# and hive-open-pr likewise never rely on inherited token env.
#
# Residual (documented, closed elsewhere): a same-uid agent can still read a
# backend CLI's /proc/<pid>/environ deliberately. That extraction lane — and
# any smuggled credential — is closed at the transport by the MITM proxy's
# Authorization strip/inject (#1861, PR #4032): the proxy, not the agent env,
# decides what credential GitHub ever sees.
# Residual (documented, OPEN today): a same-uid agent can still read a backend
# CLI's /proc/<pid>/environ deliberately. Until the MITM proxy's Authorization
# strip/inject lands (#1861, PR #4032), that extraction lane remains open: any
# smuggled credential is still usable against GitHub. Once #1861/#4032 lands,
# the proxy, not the agent env, will decide what credential GitHub ever sees.
#
# POSIX sh compatible (dash-safe): no bashisms, and `unset` of an absent
# variable is not an error. Keep the variable list in sync with
Expand Down
Loading