Skip to content

[sec-check] fix(dashboard): cap decompressed audit log reads (readAuditLogFile) to defuse gzip bombs #4863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clubanderson merged 1 commit into from
Aug 27, 2026
Merged

[sec-check] fix(dashboard): cap decompressed audit log reads (readAuditLogFile) to defuse gzip bombs #4863

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/pkg/dashboard/audit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,15 @@ func auditLogFiles(filePath string) []string {
return files
}

// maxAuditFileReadBytes caps how many decompressed bytes readAuditLogFile will
// load from a single audit file. Lumberjack rotates at auditMaxSizeMB (5MB), so
// a legitimate file — compressed or not — decompresses to roughly that size.
// Without a cap, a crafted or corrupted ".gz" in /data (a gzip bomb: a few KB
// expanding to many GB) would let io.ReadAll exhaust dashboard memory. 64MB is
// >10x the rotation size, so no legitimate file is ever truncated; a truncated
// trailing line simply fails json.Unmarshal and is skipped by the caller.
const maxAuditFileReadBytes = 64 << 20

func readAuditLogFile(path string) ([]byte, error) {
f, err := os.Open(path)
if err != nil {
Expand All @@ -265,7 +274,7 @@ func readAuditLogFile(path string) ([]byte, error) {
defer gz.Close()
r = gz
}
return io.ReadAll(r)
return io.ReadAll(io.LimitReader(r, maxAuditFileReadBytes))
}

func (a *AuditLog) Recent(n int) []AuditEntry {
Expand Down
Loading