Skip to content

[quality] deflake TestDeliverStartupKick_Delivered: gate readiness clock on actual pane render #4875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clubanderson merged 1 commit into from
Aug 27, 2026
Merged

[quality] deflake TestDeliverStartupKick_Delivered: gate readiness clock on actual pane render #4875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/pkg/agent/branches_coverage_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,13 @@ func TestDeliverStartupKick_Delivered(t *testing.T) {
agent.State = StateRunning
agent.launchGen = 3
paneInject(t, session, "goose is ready")
// Don't start deliverStartupKick's readiness clock until tmux has actually
// painted the marker: on a loaded runner the render can outlast
// paneInject's fixed sleep AND the TestMain-shrunk cliReadyTimeout,
// dropping the kick and flaking this test for reasons unrelated to the
// delivery path under test. Same pattern as
// TestDeliverStartupKick_BobReceivesKick (#4871).
requirePaneShows(t, session, "goose is ready")
m.deliverStartupKick(agent, "bootstrap prompt", 3)
if agent.LastKick == nil {
t.Error("startup kick should be delivered on matching generation")
Expand Down
Loading