Skip to content

🧪 test(hub): cover budgetSpendPerDay and mergeAcceptanceRate in quadrant_attach.go - #4957

Merged
clubanderson merged 1 commit into
v4from
quality/test-quadrant-attach-rates
Aug 28, 2026
Merged

🧪 test(hub): cover budgetSpendPerDay and mergeAcceptanceRate in quadrant_attach.go#4957
clubanderson merged 1 commit into
v4from
quality/test-quadrant-attach-rates

Conversation

@kubestellar-hive

@kubestellar-hive kubestellar-hive Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Test Improvement

Adds src/pkg/hub/quadrant_attach_rates_test.go covering the two quadrant evidence-normalisation helpers in src/pkg/hub/quadrant_attach.go:

  • budgetSpendPerDay (18.2% → 90.9%): nil spend, zero window start, sub-six-hour window noise floor, future window start (clock skew), exact-floor acceptance, daily-rate math, and real zero spend.
  • mergeAcceptanceRate (33.3% → 100%): nil merged/rejected counters, the minPRsForReworkRate floor, and 0.0/0.75/1.0 rate cases.

Claimed cluster: src/pkg/hub/quadrant_attach.go rate helpers only — disjoint from open PR #4931 (dashboard readout handlers) and all other open test PRs.

Verified: go test ./pkg/hub/ passes.

Filed by quality agent (hold-gated mode). Human review required.

— hive: agent=quality backend=copilot model=claude-fable-5

sec-check
[quality] test(hub): cover budgetSpendPerDay and mergeAcceptanceRate …
58c1ab6 
…in quadrant_attach.go

budgetSpendPerDay was at 18.2% and mergeAcceptanceRate at 33.3%. Table
tests now cover the nil-signal, zero-window, six-hour floor, clock-skew,
and PR-count-floor guards plus the happy-path rates, bringing them to
90.9% and 100%.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Aug 28, 2026
@kubestellar-prow

kubestellar-prow Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but does not touch CHANGELOG.md.

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a line under ## Unreleased. If it is a refactor, a
test-only change, or dependency churn, no entry is needed and you can
ignore this.

This is a reminder, not a gate; it never blocks a merge.

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 28, 2026
@kubestellar-hive kubestellar-hive Bot added quality testing agent/quality Approved by a Hive merger/owner for auto-merge on green CI hive/hosted-available-oke-11-placeholder-r05x Approved by a Hive merger/owner for auto-merge on green CI labels Aug 28, 2026
@clubanderson
clubanderson merged commit 7e7bacc into v4 Aug 28, 2026
42 of 43 checks passed
@clubanderson
clubanderson deleted the quality/test-quadrant-attach-rates branch August 28, 2026 13:01
@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@kubestellar-hive kubestellar-hive Bot mentioned this pull request Aug 28, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

agent/quality Approved by a Hive merger/owner for auto-merge on green CI copilot dco-signoff: yes Indicates the PR's author has signed the DCO. hive/hosted-available-oke-11-placeholder-r05x Approved by a Hive merger/owner for auto-merge on green CI hold quality size/L Denotes a PR that changes 100-499 lines, ignoring generated files. testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@clubanderson