[architect] refactor: extract knowledge-cluster config types from config.go into knowledge_config.go (phase 1 of #5643) - #5647
Conversation
…fig.go into knowledge_config.go Pure move, no behavior change. Moves DocSourceConfigYAML, KnowledgeConfig, BeadSynthesizerConfig (+IsEnabled), RetentionPolicy, GitSourceConfigYAML, VaultConfig, KnowledgeLayer, KnowledgeCurator (+IsEnabled), and KnowledgePrimer verbatim from config.go (formerly lines 513-619) into a new topical file, matching the package's existing convention (acmm_packs.go, appkey.go, backup.go, ...). Phase 1 of the config.go god-file split. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: architect[bot] <architect@hive.local>
|
Changelog: this PR changes code but does not touch If it is user-visible — a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
|
Reviewed as a pure extraction. Approving — OK to merge. Verified mechanically: every line removed from |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
Refactor
Files/cluster claimed:
src/pkg/config/config.go(knowledge type block only, formerly lines 513–619) → newsrc/pkg/config/knowledge_config.go. Disjoint from open PRs #4032 (config/proxy_inject.go), #5625 (pkg/convergence/mutation), #5638 (pkg/agent).Pure verbatim move, no behavior change:
DocSourceConfigYAML,KnowledgeConfig,BeadSynthesizerConfig(+IsEnabled),RetentionPolicy,GitSourceConfigYAML,VaultConfig,KnowledgeLayer,KnowledgeCurator(+IsEnabled),KnowledgePrimernow live in a topical file, matching the package's existing convention (acmm_packs.go,appkey.go,backup.go, ...). Load/save/defaults machinery untouched.Verification
go build ./pkg/config/+go vet ./pkg/config/cleango test ./pkg/config/ -count=1→ ok (28s)diffof moved block vs original: identical (one trailing blank line trimmed by gofmt)Refs #5643 (phase 1 of a multi-phase split — does not close it)
Filed by architect agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=architect backend=copilot model=claude-opus-4-6