Skip to content

[architect] refactor: extract knowledge-cluster config types from config.go into knowledge_config.go (phase 1 of #5643) - #5647

Merged
kubestellar-prow[bot] merged 1 commit into
v4from
arch/refactor-config-knowledge-split
Sep 2, 2026
Merged

[architect] refactor: extract knowledge-cluster config types from config.go into knowledge_config.go (phase 1 of #5643)#5647
kubestellar-prow[bot] merged 1 commit into
v4from
arch/refactor-config-knowledge-split

Conversation

@kubestellar-hive

Copy link
Copy Markdown
Contributor

Refactor

Files/cluster claimed: src/pkg/config/config.go (knowledge type block only, formerly lines 513–619) → new src/pkg/config/knowledge_config.go. Disjoint from open PRs #4032 (config/proxy_inject.go), #5625 (pkg/convergence/mutation), #5638 (pkg/agent).

Pure verbatim move, no behavior change: DocSourceConfigYAML, KnowledgeConfig, BeadSynthesizerConfig (+IsEnabled), RetentionPolicy, GitSourceConfigYAML, VaultConfig, KnowledgeLayer, KnowledgeCurator (+IsEnabled), KnowledgePrimer now live in a topical file, matching the package's existing convention (acmm_packs.go, appkey.go, backup.go, ...). Load/save/defaults machinery untouched.

Verification

  • go build ./pkg/config/ + go vet ./pkg/config/ clean
  • go test ./pkg/config/ -count=1 → ok (28s)
  • diff of moved block vs original: identical (one trailing blank line trimmed by gofmt)

Refs #5643 (phase 1 of a multi-phase split — does not close it)


Filed by architect agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.

— hive: agent=architect backend=copilot model=claude-opus-4-6

…fig.go into knowledge_config.go

Pure move, no behavior change. Moves DocSourceConfigYAML, KnowledgeConfig,
BeadSynthesizerConfig (+IsEnabled), RetentionPolicy, GitSourceConfigYAML,
VaultConfig, KnowledgeLayer, KnowledgeCurator (+IsEnabled), and
KnowledgePrimer verbatim from config.go (formerly lines 513-619) into a new
topical file, matching the package's existing convention (acmm_packs.go,
appkey.go, backup.go, ...).

Phase 1 of the config.go god-file split.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: architect[bot] <architect@hive.local>
@kubestellar-hive kubestellar-hive Bot added the hold label Sep 2, 2026
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but does not touch CHANGELOG.md.

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a line under ## Unreleased. If it is a refactor, a
test-only change, or dependency churn, no entry is needed and you can
ignore this.

This is a reminder, not a gate; it never blocks a merge.

@clubanderson

Copy link
Copy Markdown
Member

Reviewed as a pure extraction. Approving — OK to merge.

Verified mechanically: every line removed from config.go appears verbatim in knowledge_config.go — the only additions are the package clause and a five-line header comment. No type, tag, method body, or doc comment differs (including the deliberate KnowledgeCurator.IsEnabled default-false vs BeadSynthesizerConfig default-true asymmetry, which moves intact). Same package, no import changes, no reference elsewhere breaks. Zero behavior change; matches the package's existing topical-file convention.

@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed hold labels Sep 2, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
kubestellar-prow Bot merged commit 9985593 into v4 Sep 2, 2026
55 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the arch/refactor-config-knowledge-split branch September 2, 2026 13:32
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. copilot dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant