[architect] refactor: remove dead pkg/hub Go SVG quadrant renderer (quadrant_render.go) - #5747
Conversation
…render.go) The quadrant kite is rendered client-side by the JavaScript reimplementation embedded in saas.go (quadrantPolygonPoints/quadrantSVG/ quadrantAriaLabel). Every function in pkg/hub/quadrant_render.go is unreachable from all binaries per 'deadcode ./cmd/...'. Remove the file, its test file, and the TestDeltaSignAndAbs case in small_seams_test.go that only exercised symbols defined there. Live quadrant scoring (quadrant.go, quadrant_score.go, quadrant_axes.go, quadrant_attach.go) is untouched. Refs #5745, part of #5694. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible — a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
clubanderson
left a comment
There was a problem hiding this comment.
Reviewed the full deletion and verified the removed Go SVG renderer symbols are not called from v4 product code; current dashboard rendering uses the JavaScript implementation in saas.go. Also checked v5 references: only the same orphan Go file/tests plus JS renderer remain, with no product call into the Go renderer. go build ./... and go test ./pkg/hub pass.
|
LGTM label has been added. DetailsGit tree hash: 0ac8acd9d67658b9c3b5ed906a3da9730c780bf1 |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Andy Anderson <andy@clubanderson.com>
clubanderson
left a comment
There was a problem hiding this comment.
Re-reviewed after adding the required changelog fragment. The removal remains limited to an unused Go renderer/tests; build and hub package tests passed.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 632ba4adb43bf735db52f915ce63cbcd3462172c |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Andy Anderson <andy@clubanderson.com>
clubanderson
left a comment
There was a problem hiding this comment.
Re-reviewed after renaming the changelog fragment to the guard's required category format. Verdict remains approve.
|
LGTM label has been added. DetailsGit tree hash: f4ec5002614e4c38725fc2b0fe49368ef5cff5cb |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
Refactor
Deletes
src/pkg/hub/quadrant_render.go(228 LOC) andquadrant_render_test.go, and dropsTestDeltaSignAndAbsfromsmall_seams_test.go. -382 LOC, no additions.Claimed ground: exactly
pkg/hub/quadrant_render.go,pkg/hub/quadrant_render_test.go, and theTestDeltaSignAndAbscase inpkg/hub/small_seams_test.go— the dead Go functionsquadrantPoint,quadrantPolygon,axisByName,quadrantSVG,axisShortLabel,deltaSign,abs,quadrantAriaLabel. Disjoint from PR #5697 (wrapkey* envelope encryption) and every other open PR.Why it is dead: the quadrant kite is rendered client-side by the JS reimplementation embedded in
saas.go(~line 10714) —quadrant_dashboard_test.goasserts those JS functions exist in the served page.deadcode ./cmd/...reports every function in the Go file unreachable; the only callers were its own tests.Untouched: live quadrant scoring —
quadrant.go,quadrant_score.go,quadrant_axes.go,quadrant_attach.go— and the JS renderer insaas.go.Validation:
go build ./...,go vet ./pkg/hub/,go test ./pkg/hub/all green.Fixes #5745. Part of the #5694 dead-code inventory (non-closing).
Filed by architect agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=architect backend=copilot model=claude-opus-4-6