Skip to content

[architect] refactor: remove dead pkg/hub Go SVG quadrant renderer (quadrant_render.go) - #5747

Merged
clubanderson merged 3 commits into
v4from
arch/remove-dead-quadrant-render
Sep 3, 2026
Merged

[architect] refactor: remove dead pkg/hub Go SVG quadrant renderer (quadrant_render.go)#5747
clubanderson merged 3 commits into
v4from
arch/remove-dead-quadrant-render

Conversation

@kubestellar-hive

Copy link
Copy Markdown
Contributor

Refactor

Deletes src/pkg/hub/quadrant_render.go (228 LOC) and quadrant_render_test.go, and drops TestDeltaSignAndAbs from small_seams_test.go. -382 LOC, no additions.

Claimed ground: exactly pkg/hub/quadrant_render.go, pkg/hub/quadrant_render_test.go, and the TestDeltaSignAndAbs case in pkg/hub/small_seams_test.go — the dead Go functions quadrantPoint, quadrantPolygon, axisByName, quadrantSVG, axisShortLabel, deltaSign, abs, quadrantAriaLabel. Disjoint from PR #5697 (wrapkey* envelope encryption) and every other open PR.

Why it is dead: the quadrant kite is rendered client-side by the JS reimplementation embedded in saas.go (~line 10714) — quadrant_dashboard_test.go asserts those JS functions exist in the served page. deadcode ./cmd/... reports every function in the Go file unreachable; the only callers were its own tests.

Untouched: live quadrant scoring — quadrant.go, quadrant_score.go, quadrant_axes.go, quadrant_attach.go — and the JS renderer in saas.go.

Validation: go build ./..., go vet ./pkg/hub/, go test ./pkg/hub/ all green.

Fixes #5745. Part of the #5694 dead-code inventory (non-closing).


Filed by architect agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.

— hive: agent=architect backend=copilot model=claude-opus-4-6

…render.go)

The quadrant kite is rendered client-side by the JavaScript
reimplementation embedded in saas.go (quadrantPolygonPoints/quadrantSVG/
quadrantAriaLabel). Every function in pkg/hub/quadrant_render.go is
unreachable from all binaries per 'deadcode ./cmd/...'. Remove the file,
its test file, and the TestDeltaSignAndAbs case in small_seams_test.go
that only exercised symbols defined there.

Live quadrant scoring (quadrant.go, quadrant_score.go, quadrant_axes.go,
quadrant_attach.go) is untouched.

Refs #5745, part of #5694.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
@kubestellar-hive kubestellar-hive Bot added the hold label Sep 2, 2026
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2026
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly — that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@clubanderson clubanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full deletion and verified the removed Go SVG renderer symbols are not called from v4 product code; current dashboard rendering uses the JavaScript implementation in saas.go. Also checked v5 references: only the same orphan Go file/tests plus JS renderer remain, with no product call into the Go renderer. go build ./... and go test ./pkg/hub pass.

@kubestellar-prow kubestellar-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 0ac8acd9d67658b9c3b5ed906a3da9730c780bf1

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>

@clubanderson clubanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed after adding the required changelog fragment. The removal remains limited to an unused Go renderer/tests; build and hub package tests passed.

@kubestellar-prow kubestellar-prow Bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Sep 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from clubanderson. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 632ba4adb43bf735db52f915ce63cbcd3462172c

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2026

@clubanderson clubanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed after renaming the changelog fragment to the guard's required category format. Verdict remains approve.

@kubestellar-prow kubestellar-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: f4ec5002614e4c38725fc2b0fe49368ef5cff5cb

@clubanderson
clubanderson merged commit 2c00350 into v4 Sep 3, 2026
52 of 55 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the arch/remove-dead-quadrant-render branch September 3, 2026 01:54
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copilot dco-signoff: yes Indicates the PR's author has signed the DCO. hold lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[architect] pkg/hub/quadrant_render.go: dead Go SVG renderer superseded by the JS renderer embedded in saas.go

1 participant