[guide] docs: drop dead dashboard.snapshot_dir from hive.yaml.example and 4 deploy templates - #6193
Merged
Merged
Conversation
dashboard.snapshot_dir is parsed (config.go:3743) but read nowhere: nous snapshots hardcode /data/nous/snapshots and /snapshot is driven by hub.auto_snapshot. Remove the misleading row from hive.yaml.example and the four deploy templates so operators stop tuning a no-op knob. Refs #6192 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
kubestellar-prow
Bot
added
the
dco-signoff: yes
kubestellar-prow
Bot
added
the
size/XS
clubanderson
added
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
clubanderson
added a commit
that referenced
this pull request
Sep 8, 2026
dashboard.snapshot_dir was parsed into DashboardConfig.SnapshotDir but never read: nous baseline snapshots hardcode /data/nous/snapshots and the public /snapshot page is driven by hub.auto_snapshot. #6193 dropped the row from hive.yaml.example and the four src/deploy templates; this removes the last template line from bin/hive-setup.sh, deletes the unused Go field, and drops the config_test.go fixture line. The config loader uses plain yaml.Unmarshal (no KnownFields/strict mode), so existing hive.yaml files that still set the key continue to load unchanged. Fixes #6192 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
clubanderson
added a commit
that referenced
this pull request
Sep 8, 2026
dashboard.snapshot_dir was parsed into DashboardConfig.SnapshotDir but never read: nous baseline snapshots hardcode /data/nous/snapshots and the public /snapshot page is driven by hub.auto_snapshot. #6193 dropped the row from hive.yaml.example and the four src/deploy templates; this removes the last template line from bin/hive-setup.sh, deletes the unused Go field, and drops the config_test.go fixture line. The config loader uses plain yaml.Unmarshal (no KnownFields/strict mode), so existing hive.yaml files that still set the key continue to load unchanged. Fixes #6192 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
kubestellar-prow Bot
pushed a commit
that referenced
this pull request
Sep 8, 2026
dashboard.snapshot_dir was parsed into DashboardConfig.SnapshotDir but never read: nous baseline snapshots hardcode /data/nous/snapshots and the public /snapshot page is driven by hub.auto_snapshot. #6193 dropped the row from hive.yaml.example and the four src/deploy templates; this removes the last template line from bin/hive-setup.sh, deletes the unused Go field, and drops the config_test.go fixture line. The config loader uses plain yaml.Unmarshal (no KnownFields/strict mode), so existing hive.yaml files that still set the key continue to load unchanged. Fixes #6192 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
kubestellar-hive Bot
added a commit
that referenced
this pull request
Sep 8, 2026
…6193) dashboard.snapshot_dir is parsed (config.go:3743) but read nowhere: nous snapshots hardcode /data/nous/snapshots and /snapshot is driven by hub.auto_snapshot. Remove the misleading row from hive.yaml.example and the four deploy templates so operators stop tuning a no-op knob. Refs #6192 Signed-off-by: sec-check <sec-check@hive.kubestellar.io> Co-authored-by: sec-check <sec-check@hive.kubestellar.io> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
kubestellar-hive Bot
pushed a commit
that referenced
this pull request
Sep 8, 2026
dashboard.snapshot_dir was parsed into DashboardConfig.SnapshotDir but never read: nous baseline snapshots hardcode /data/nous/snapshots and the public /snapshot page is driven by hub.auto_snapshot. #6193 dropped the row from hive.yaml.example and the four src/deploy templates; this removes the last template line from bin/hive-setup.sh, deletes the unused Go field, and drops the config_test.go fixture line. The config loader uses plain yaml.Unmarshal (no KnownFields/strict mode), so existing hive.yaml files that still set the key continue to load unchanged. Fixes #6192 Signed-off-by: Andrew Anderson <andy@clubanderson.com> Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation Fix
Removes the
dashboard.snapshot_dir: /data/snapshotsrow from the five shipped config templates:src/hive.yaml.example(line 492)src/deploy/hive.yamlsrc/deploy/architect-only.yamlsrc/deploy/hive-level2-knuckle.yamlsrc/deploy/hive-level3-knuckle.yamlThe key is parsed into
DashboardConfig.SnapshotDir(src/pkg/config/config.go:3743) but never read anywhere insrc/: nous baseline snapshots hardcode/data/nous/snapshots(src/cmd/hive/main.go:9207), and the public/snapshotpage is driven byhub.auto_snapshot, not a directory setting. Operators setting this knob change nothing, and its position next tosnapshot_frame_ancestorsimplies it controls/snapshot.Deliberately not touched here (code — architect follow-up per the issue): the dead Go struct field, the
config_test.go:60fixture line, and the heredoc row inbin/hive-setup.sh.Includes
changelog.d/fixed-6192-dead-snapshot-dir.md.Refs #6192 (docs/templates half only; issue stays open for the code-side field removal)
Filed by guide agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=guide backend=copilot model=claude-sonnet-4-6