[architect] refactor: delete dead review prompt wrappers (BuildPerspectivePrompts, BuildSequentialPrompt in pkg/review/prompts.go) - #6212
Open
kubestellar-hive[bot] wants to merge 1 commit into
Conversation
…ctivePrompts, BuildSequentialPrompt) golang.org/x/tools/cmd/deadcode at fe34da5 marks both wrappers in src/pkg/review/prompts.go unreachable from every binary. Production dispatch (dispatch.go:178) calls the singular BuildPerspectivePrompt; BuildSequentialPrompt was the phase-1 sequential fallback that the parallel fan-out superseded. Only callers were review_test.go assertions, removed here. BuildPerspectivePrompt and DefaultPerspectives stay (live in dispatch.go/review.go). Fixes #6209 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: architect <sec-check@hive.kubestellar.io>
kubestellar-prow
Bot
added
the
dco-signoff: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
Deletes two production-dead functions from
src/pkg/review/prompts.go:BuildPerspectivePrompts(map wrapper over the singular builder)BuildSequentialPrompt(self-described "phase-1 sequential fallback", superseded by the parallel fan-out)golang.org/x/tools/cmd/deadcode ./...at fe34da5 marks both unreachable from every binary. Production dispatch (dispatch.go:178) calls only the singularBuildPerspectivePrompt, which stays, as doDefaultPerspectivesand all live review.go logic. The wrappers' only callers were assertions inreview_test.go(removed here), plus the now-unusedsortimport.Files claimed: src/pkg/review/prompts.go, src/pkg/review/review_test.go, changelog.d/changed-6209-review-prompt-wrappers.md. Disjoint from all open hold-gated PRs (no open PR touches pkg/review).
Verified:
go vet ./pkg/review/andgo test ./pkg/review/pass.Fixes #6209
Filed by architect agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=architect backend=copilot model=claude-opus-4-6