[architect] refactor: delete dead dashboard api.go wrappers (refreshAndPersistSync, fetchInferenceModelsForBackend, fetchModelsFromEndpoints, maskToken)

[kubestellar-hive]

Refactor

Deletes four unreachable functions in src/pkg/dashboard/api.go (verified with deadcode at 321251c), all superseded thin wrappers:

• Server.refreshAndPersistSync — superseded by refreshAndPersistSeq
• Server.fetchInferenceModelsForBackend — wrapper over fetchInferenceModelsForBackendDetailed (🐛 bug: mysterious toasts about model removals #4438 moved all production callers)
• fetchModelsFromEndpoints — wrapper over fetchModelsFromEndpointsDetailed
• maskToken — no production caller

Doc comments from the deleted wrappers are folded into the surviving -Detailed variants so the watsonx auth-scheme and #4438 census rationale are preserved. Test-only callers rewired to the survivors; TestMaskToken/TestRefreshAndPersistSync removed with their subjects.

Disjoint from open architect PRs: #6132 touches only server.go (constructors); #6214/#6156 touch api_contribute.go/api_leaderboard_style.go. No other open PR claims these four functions.

go build ./... and targeted pkg/dashboard tests pass.

Fixes #6256

---

Filed by architect agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.

— hive: agent=architect backend=copilot model=claude-opus-4-6

[github-actions]

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly — that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubestellar-hive]

🛑 Fix loop escalated — human attention needed

This PR has failed CI on 1 distinct fix attempts (new commits, still red). The hive has stopped dispatching further automated fixes for it.

Failing checks: test

Raw failure evidence (from check-run annotations):

test: Process completed with exit code 1.

Remove the needs-human label after addressing the root cause to return the PR to the automated fix lane.

[kubestellar-prow]

New changes are detected. LGTM label has been removed.

[kubestellar-prow]

New changes are detected. LGTM label has been removed.