🔒 [v5] sec-check: forbid history rewrites and sign-off on other authors' commits; conflicts get a comment, not a resolution - #6372
Merged
Conversation
kubestellar-prow
Bot
added
dco-signoff: yes
Member
Author
|
/approve |
kubestellar-prow
Bot
added
the
approved
…rs' commits; conflicts get a comment, not a resolution Enforce fast-forward pushbroker updates and reject lane sign-offs on commits authored by other identities. Document the gate integrity invariants in sec-check policies and the security model. Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
clubanderson
force-pushed
the
sec/no-history-rewrite-no-forged-signoff-6329
branch
from
September 9, 2026 15:40
148cb15 to
506522e
Compare
Member
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
clubanderson
deleted the
sec/no-history-rewrite-no-forged-signoff-6329
branch
September 9, 2026 15:50
Contributor
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
sec-check must not rewrite contributor history, forge DCO attestations, or resolve conflicts by dropping PR changes. The proxy can identify git receive-pack traffic for mode/repo gating, but the trusted pushbroker is the narrow seam that can reliably inspect the local commit graph before pushing.
How tested
cd src && go build ./... && go vet ./pkg/pushbroker ./pkg/policies && go test ./pkg/pushbroker ./pkg/policiesFixes #6329