🔒 [v5] ci-maintainer/sec-check: retrigger CI via run rerun, never by pushing to a reviewed PR branch - #6373
Merged
Merged
Conversation
…pushing to a reviewed PR branch Reject empty outgoing commits in the pushbroker and document CI rerun rules for ci-maintainer and sec-check lanes. Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kubestellar-prow
Bot
added
dco-signoff: yes
Reject commits that become empty when broker newline normalisation amends the agent's outgoing change. Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep first-push empty-commit checks scoped to the brokered HEAD commit so historical empty commits do not block real new branch work. Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add pushbroker tests for empty-commit guard failure paths and head-only first-push handling to restore package coverage above the gate. Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
approved
Contributor
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
gh run rerun <run-id> --failedor workflow_dispatch instead of branch pushes, skips reviewed/green PRs, and honorsHIVE_CI_RETRIGGER_COOLDOWN_MINUTES(default 30 minutes) after maintainer cancellations.Why
Pushing empty/no-op commits to PR branches resets review state in Prow-managed repos and should never be used as a CI retrigger mechanism. I found no existing Go retrigger loop to convert to the runs API, so this PR adds policy coverage and push-time enforcement for the branch-push failure mode.
How tested
cd src && go build ./... && go vet ./pkg/pushbroker ./pkg/policies && go test ./pkg/pushbroker ./pkg/policiesFixes #6300