getName method return type changed as nullable

hkulekci · Aug 9, 2023 · 9ea7520 · 9ea7520
1 parent 5b69412
commit 9ea7520
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/src/Models/MultiVectorStruct.php b/src/Models/MultiVectorStruct.php
@@ -20,7 +20,7 @@ public function addVector(string $name, array $vector): void
         $this->vectors[$name] = $vector;
     }
 
-    public function getName(): string
+    public function getName(): ?string
     {
         if(empty($this->vectors)) {
             throw new InvalidArgumentException("No vectors added yet");

diff --git a/src/Models/VectorStruct.php b/src/Models/VectorStruct.php
@@ -26,7 +26,7 @@ public function isNamed(): bool
         return $this->name !== null;
     }
 
-    public function getName(): string
+    public function getName(): ?string
     {
         return $this->name;
     }

diff --git a/src/Models/VectorStructInterface.php b/src/Models/VectorStructInterface.php
@@ -9,7 +9,7 @@ interface VectorStructInterface
      *
      * @return string
      */
-    public function getName(): string;
+    public function getName(): ?string;
 
     /**
      * Convert this vector to a search array.

diff --git a/tests/Unit/Models/VectorStructTest.php b/tests/Unit/Models/VectorStructTest.php
@@ -46,4 +46,11 @@ public function testNamedVectorStruct(): void
             $vector->toSearchArray()
         );
     }
+
+    public function testGetNameWithNullValue(): void
+    {
+        $vector = new VectorStruct([1, 2, 3]);
+
+        $this->assertNull($vector->getName());
+    }
 }