Support limit for Points scroll #33
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
============================================
+ Coverage 87.60% 87.99% +0.38%
- Complexity 278 291 +13
============================================
Files 57 58 +1
Lines 936 966 +30
============================================
+ Hits 820 850 +30
Misses 116 116
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Hey @yunwuxin, good catch. Thanks for your contribution! Could you add a test for its parameter? |
|
Hey @yunwuxin, you are fantastic. I will check again after the pipeline. |
| if ($scrollParams instanceof Filter) { | ||
| $body['filter'] = $scrollParams->toArray(); | ||
| } elseif ($scrollParams instanceof ScrollRequest) { | ||
| $body = $scrollParams->toArray(); |
There was a problem hiding this comment.
I guess we can keep for now Filter for bc break. But at the end, we need to remove it. We can pass filter by using request too.
|
Thanks for contribution ✌️🔥 merged! |
No description provided.