MPI Window #1
Closed
MPI Window #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmenke
reviewed
Jan 22, 2025
c++/mpi/window.hpp
Outdated
| @@ -36,6 +38,8 @@ namespace mpi { | |||
| class window { | |||
| friend class shared_window<BaseType>; | |||
| MPI_Win win{MPI_WIN_NULL}; | |||
| BaseType* base_local{nullptr}; | |||
There was a problem hiding this comment.
Suggested change
| BaseType* base_local{nullptr}; | |
| public: | |
| std::span<BaseType> base; |
c++/mpi/window.hpp
Outdated
| MPI_Datatype target_datatype = mpi_type<TargetType>::get(); | ||
| MPI_Get(origin_addr, origin_count, origin_datatype, target_rank, target_disp, target_count_, target_datatype, win); | ||
| } else { | ||
| if ((sizeof(OriginType) * origin_count) >= (sizeof(TargetType) * target_count_)) { |
There was a problem hiding this comment.
Suggested change
| if ((sizeof(OriginType) * origin_count) >= (sizeof(TargetType) * target_count_)) { | |
| if ((sizeof(OriginType) * origin_count) >= (sizeof(TargetType) * target_count_) + target_disp) { |
Assumes that target_disp is in bytes. (Check with the standard maybe?)
c++/mpi/window.hpp
Outdated
| if ((sizeof(OriginType) * origin_count) >= (sizeof(TargetType) * target_count_)) { | ||
| std::memcpy(origin_addr, base_local + target_disp, sizeof(TargetType) * target_count_); | ||
| } else { | ||
| std::abort(); // Not enough memory |
There was a problem hiding this comment.
Remove noexcept and throw std::bad_alloc.
c++/mpi/window.hpp
Outdated
Comment on lines
201
to
225
| switch (op) { | ||
| case MPI_SUM: | ||
| for (int i = 0; i < origin_count; ++i) { | ||
| base_local[target_disp + i] += origin_addr[i]; | ||
| } | ||
| break; | ||
| case MPI_PROD: | ||
| for (int i = 0; i < origin_count; ++i) { | ||
| base_local[target_disp + i] *= origin_addr[i]; | ||
| } | ||
| break; | ||
| case MPI_MIN: | ||
| for (int i = 0; i < origin_count; ++i) { | ||
| base_local[target_disp + i] = std::min(base_local[target_disp + i], origin_addr[i]); | ||
| } | ||
| break; | ||
| case MPI_MAX: | ||
| for (int i = 0; i < origin_count; ++i) { | ||
| base_local[target_disp + i] = std::max(base_local[target_disp + i], origin_addr[i]); | ||
| } | ||
| break; | ||
| default: | ||
| std::cerr << "Error: Unsupported operation." << std::endl; | ||
| std::abort(); | ||
| } |
There was a problem hiding this comment.
For now just std::abort. We have to think of a usable solution. Maybe have a look at what all_reduce does without has_env.
hmenke
force-pushed
the
shm
branch
2 times, most recently
from
7a4661b to
9b51e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.