Skip to content

PIL - 1822 : Submission history with Amendment #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/models/obligationsandsubmissions/Submission.scala
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ object SubmissionType extends Enum[SubmissionType] with PlayJsonEnum[SubmissionT
override val fullName: String = "UK Tax Return"
}
case object UKTR_AMEND extends SubmissionType {
override val fullName: String = "UK Tax Return Amend"
override val fullName: String = "UK Tax Return amendment"
}
case object ORN_CREATE extends SubmissionType {
override val fullName: String = "Overseas Return Notification Create"
override val fullName: String = "Overseas Return Notification"
}
case object ORN_AMEND extends SubmissionType {
override val fullName: String = "Overseas Return Notification Amend"
override val fullName: String = "Overseas Return Notification amendment"
}
case object BTN extends SubmissionType {
override val fullName: String = "Below-Threshold Notification"
Expand Down
4 changes: 2 additions & 2 deletions conf/messages.en
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,8 @@ submissionHistory.heading = Submission history
submissionHistory.group.p1 = You can find all submissions and amendments made by your group during this accounting period and the previous 6 accounting periods.
submissionHistory.group.p2 = Where you’ve made changes to a tax return or information return, we’ll list these as individual submissions.
submissionHistory.agent.p1 = You can find all submissions and amendments made by your client during this accounting period and the previous 6 accounting periods.
submissionHistory.agent.p2 = When your client makes changes to a tax return or information return, we’ll list these as individual submissions.
submissionHistory.insetText = You can amend your submissions at any time, except for the UK Tax Return, which must be updated within 12 months of the submission deadline.
submissionHistory.agent.p2 = Where your client makes changes to a tax return or information return, we’ll list these as individual submissions.
submissionHistory.insetText = You can amend submissions at any time, except for the UK Tax Return, which must be updated within 12 months of the submission deadline.
submissionHistory.typeOfReturn = Type of return
submissionHistory.submissionDate = Submission date
submissionHistory.h2 = Due and overdue returns
Expand Down
4 changes: 2 additions & 2 deletions test/views/submissionhistory/SubmissionHistoryViewSpec.scala
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class SubmissionHistoryViewSpec extends ViewSpecBase with SubmissionHistoryDataF

"have a inset text" in {
organisationView.getElementsByClass("govuk-inset-text").text must include(
"You can amend your submissions at any time, except for the UK Tax Return, which must be updated within 12 months of the submission deadline."
"You can amend submissions at any time, except for the UK Tax Return, which must be updated within 12 months of the submission deadline."
)
}

Expand Down Expand Up @@ -103,7 +103,7 @@ class SubmissionHistoryViewSpec extends ViewSpecBase with SubmissionHistoryDataF
"You can find all submissions and amendments made by your client during this accounting period and the previous 6 accounting periods."
)
paragraph.get(2).text must include(
"When your client makes changes to a tax return or information return, we’ll list these as individual submissions."
"Where your client makes changes to a tax return or information return, we’ll list these as individual submissions."
)
}

Expand Down