Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

Adding Support for Indices #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding Support for Indices #61

wants to merge 1 commit into from

Conversation

rubicon9
Copy link

@rubicon9 rubicon9 commented Aug 6, 2017

  • Adding token ^
  • Updating order of operation to include indices
  • Adding action for new #indices (using php pow function)
  • NB, tests delayed since it appears the suite is already failing?

@rubicon9
Adding Support for Indices
27f4c75 
- Adding token ^
- Updating order of operation to include indices
- Adding action for new #indices (using php pow function)
- NB, tests delayed since it appears the suite is already failing?
@Hywan Hywan self-assigned this Aug 7, 2017
Hywan
Hywan suggested changes Aug 7, 2017
View reviewed changes
Copy link
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this PR! Really appreciated. This relates to #25 and #26. You must read the latter PR (cc @osaris) where we have a discussion about testing and the ^ operator.

Arithmetic.pp
@@ -49,6 +49,7 @@
%token minus \-|−
%token times \*|×
%token div /|÷
%token indices \^
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using the token name pow?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think using either indices or exponent would be more correct but it's a trivial thing, I don't mind either way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hywan Hywan Hywan requested changes

Assignees

@Hywan Hywan

Labels
difficulty: hard enhancement in progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubicon9 @Hywan