libopus feature for ffmpeg

[sethvincent]

No description provided.

[kasperisager]

The libopus build definition must be in a separate port, see https://github.com/holepunchto/bare-ffmpeg/blob/main/cmake/ports/svt-av1/port.cmake for an example. It's fortunately built with CMake as well so the port should be trivial.

[sethvincent]

@kasperisager makes sense! Is there a way around recreating the equivalent of bare_arch for checking the arch?

[kasperisager]

Is there a way around recreating the equivalent of bare_arch for checking the arch?

That shouldn't be necessary at all. What's the issue you're running into?

[tony-go]

Looks good % @kasperisager comment! :)

[sethvincent]

Is there a way around recreating the equivalent of bare_arch for checking the arch?

That shouldn't be necessary at all. What's the issue you're running into?

Ah, I see, I guess I was assuming because of this in the x264 port, which we could probably remove?

bare-ffmpeg/cmake/ports/x264/port.cmake

Lines 23 to 65 in 564d5b4

	if(CMAKE_SYSTEM_NAME)
	set(platform ${CMAKE_SYSTEM_NAME})
	else()
	set(platform ${CMAKE_HOST_SYSTEM_NAME})
	endif()
	string(TOLOWER "${platform}" platform)
	if(platform MATCHES "darwin|ios")
	set(platform "darwin")
	elseif(platform MATCHES "linux|android")
	set(platform "linux")
	elseif(platform MATCHES "windows")
	set(platform "msys")
	else()
	message(FATAL_ERROR "Unsupported platform '${platform}'")
	endif()
	if(APPLE AND CMAKE_OSX_ARCHITECTURES)
	set(arch ${CMAKE_OSX_ARCHITECTURES})
	elseif(MSVC AND CMAKE_GENERATOR_PLATFORM)
	set(arch ${CMAKE_GENERATOR_PLATFORM})
	elseif(ANDROID AND CMAKE_ANDROID_ARCH_ABI)
	set(arch ${CMAKE_ANDROID_ARCH_ABI})
	elseif(CMAKE_SYSTEM_PROCESSOR)
	set(arch ${CMAKE_SYSTEM_PROCESSOR})
	else()
	set(arch ${CMAKE_HOST_SYSTEM_PROCESSOR})
	endif()
	string(TOLOWER "${arch}" arch)
	if(arch MATCHES "arm64|aarch64")
	set(arch "aarch64")
	elseif(arch MATCHES "armv7-a|armeabi-v7a")
	set(arch "arm")
	elseif(arch MATCHES "x64|x86_64|amd64")
	set(arch "x86_64")
	elseif(arch MATCHES "x86|i386|i486|i586|i686")
	set(arch "i686")
	else()
	message(FATAL_ERROR "Unsupported architecture '${arch}'")
	endif()

I got a little too into figuring out how the libopus build works with neon but I figured out the right option to make it build.

Assuming the workflow jobs succeed I think this is probably good now!

[sethvincent]

Assuming the workflow jobs succeed I think this is probably good now!

Narrator voice: "But not all the workflow jobs would succeed."

Now they do! I got really into getting simd intrinsics working across platform/arch. Possibly too into it.