-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add humidity sensor to deconz component #93024
Conversation
Hey there @Kane610, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@Kane610 Sorry to bother you, but I have a question regarding the "Low Battery" Binary Sensor. |
I would call that a bug :) |
You should use suggested_display_precision=1 instead of round. Take a look at #91924 |
I think this looks good. In worst case if the other PR is not merged in time this can probably merged as is waiting for the library to be updated |
v113 is building for pypi right now Kane610/deconz@v112...v113 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Only one small thing
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's always the last-minute change :D |
The pipeline is broken, but it seems unrelated? Wenn I rebase someone always has to start the pipeline again ... |
Rebasing fixed the pipeline I guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Xyaren 👍
../Frenck
Breaking change
Proposed change
This PR adds support for humidity sensors from deconz to be exposed to home assistant.
The api used is based on Kane610/deconz#325 in pydeconz.
This PR should be merged after:
Bump pydeconz to v112 #91924(adjustments to this PR will be made once pydeconz is released, such as the rounding which should be handled in the dependency)
I'll add tests once the PRs above are merged.
Untill then, this PR should remain in DRAFT.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: