Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add humidity sensor to deconz component #93024

Merged
merged 9 commits into from
Jun 1, 2023
Merged

Add humidity sensor to deconz component #93024

merged 9 commits into from
Jun 1, 2023

Conversation

Xyaren
Copy link
Contributor

@Xyaren Xyaren commented May 13, 2023

Breaking change

Proposed change

This PR adds support for humidity sensors from deconz to be exposed to home assistant.

The api used is based on Kane610/deconz#325 in pydeconz.

This PR should be merged after:

I'll add tests once the PRs above are merged.
Untill then, this PR should remain in DRAFT.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Kane610, mind taking a look at this pull request as it has been labeled with an integration (deconz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of deconz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign deconz Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@Xyaren
Copy link
Contributor Author

Xyaren commented May 13, 2023

@Kane610 Sorry to bother you, but I have a question regarding the "Low Battery" Binary Sensor.
Currently this shows up twice for each "Sub Sensor" of the device.
Is there any way to prevent this ?

Battery Percentage seems to be handled different:
image

@Kane610
Copy link
Member

Kane610 commented May 13, 2023

@Kane610 Sorry to bother you, but I have a question regarding the "Low Battery" Binary Sensor. Currently this shows up twice for each "Sub Sensor" of the device. Is there any way to prevent this ?

Battery Percentage seems to be handled different: image

I would call that a bug :)

@Kane610
Copy link
Member

Kane610 commented May 19, 2023

You should use suggested_display_precision=1 instead of round. Take a look at #91924

@Xyaren
Copy link
Contributor Author

Xyaren commented May 19, 2023

I'll incorporate the changes from #91924 in this PR then?
Also fix the tests mentioned in #91924

@Xyaren Xyaren requested a review from Kane610 May 19, 2023 11:47
@Kane610
Copy link
Member

Kane610 commented May 20, 2023

I think this looks good. In worst case if the other PR is not merged in time this can probably merged as is waiting for the library to be updated

@Kane610
Copy link
Member

Kane610 commented May 23, 2023

v113 is building for pypi right now Kane610/deconz@v112...v113

@Xyaren Xyaren marked this pull request as ready for review May 23, 2023 09:02
Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only one small thing

@home-assistant home-assistant bot marked this pull request as draft May 23, 2023 20:23
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Xyaren Xyaren marked this pull request as ready for review May 24, 2023 01:29
@home-assistant home-assistant bot requested a review from Kane610 May 24, 2023 01:29
Copy link
Member

@Kane610 Kane610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xyaren A test failure appeared 🙈

Could you take a look?

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft May 24, 2023 08:25
@Xyaren Xyaren marked this pull request as ready for review May 24, 2023 15:14
@home-assistant home-assistant bot requested review from frenck and Kane610 May 24, 2023 15:14
@Xyaren
Copy link
Contributor Author

Xyaren commented May 24, 2023

@Xyaren A test failure appeared 🙈

Could you take a look?

Thanks! 👍

../Frenck

It's always the last-minute change :D
Fixed.

@Xyaren
Copy link
Contributor Author

Xyaren commented May 25, 2023

The pipeline is broken, but it seems unrelated?

Wenn I rebase someone always has to start the pipeline again ...

@Xyaren
Copy link
Contributor Author

Xyaren commented Jun 1, 2023

Rebasing fixed the pipeline I guess.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Xyaren 👍

../Frenck

@frenck frenck merged commit d4e352d into home-assistant:dev Jun 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants